Page MenuHomePhabricator
Create Task
Maniphest T136543

[Bug] unable to edit in IE
Closed, ResolvedPublic
Actions

Description

We have several users complaining that editing in IE11/Win7 is broken. https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#A_bug.3F When trying to save and edit they get a "forbidden" error message which is extremely helpful ;-)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update WikibaseJanZerebeckimediawiki/extensions/Wikidatawmf/1.28.0-wmf.3+97 -93
Update WikibaseJanZerebeckimediawiki/extensions/Wikidatawmf/1.27.0-wmf.6+97 -93
Work around IE not supporting dir=autoJanZerebeckimediawiki/extensions/Wikibasewmf/1.28.0-wmf.3+6 -2
Work around IE not supporting dir=autoJanZerebeckimediawiki/extensions/Wikibasemaster+6 -2
Release 2.0.0Thiemo Kreuz (WMDE)mediawiki/extensions/WikibaseJavaScriptApimaster+12 -1
Update wikibase/javascript-api to 1.1.1JanZerebeckimediawiki/extensions/Wikidatawmf/1.28.0-wmf.3+63 -58
Release 1.1.1JanZerebeckimediawiki/extensions/WikibaseJavaScriptApi1.1.x+5 -1
Fix getLocationAgnosticMwApi behavior in Internet ExplorerJanZerebeckimediawiki/extensions/WikibaseJavaScriptApi1.1.x+6 -5
Fix getLocationAgnosticMwApi behavior in Internet ExplorerThiemo Kreuz (WMDE)mediawiki/extensions/WikibaseJavaScriptApimaster+6 -5
Replace deprecated "options" tokens with "csrf"Thiemo Kreuz (WMDE)mediawiki/extensions/Wikibasemaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Lydia_Pintscher created this task.May 30 2016, 9:00 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 30 2016, 9:00 AM
Lydia_Pintscher triaged this task as High priority.May 30 2016, 9:00 AM
Lydia_Pintscher added a subscriber: WMDE-Fisch.May 30 2016, 9:19 AM

I just checked this with @WMDE-Fisch and it is not just IE 11 but also at least IE 10. Edge seems ok.

Lydia_Pintscher renamed this task from [Bug] unable to edit in IE11/Win7 to [Bug] unable to edit in IE.May 30 2016, 9:19 AM
Lydia_Pintscher raised the priority of this task from High to Unbreak Now!.
Lydia_Pintscher added subscribers: • adrianheine, thiemowmde, • Jonas.

Based on the amount of reports we get about this we should fix it asap.

Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 30 2016, 9:20 AM
gerritbot subscribed.May 30 2016, 10:14 AM

Change 291704 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Release 2.0.0

https://gerrit.wikimedia.org/r/291704

gerritbot added a project: Patch-For-Review.May 30 2016, 10:14 AM
thiemowmde added a comment.May 30 2016, 10:17 AM

I have an old laptop with Internet Explorer 9 and can reproduce the problem there. The API request done in the background to fulfill the edit request returns:

'origin' parameter does not match Origin header

There is no origin header in the request IE sends, as far as I can see.

I believe this is not an issue we introduced in Wikibase, but something that changed in core.

http://stackoverflow.com/questions/20784209/internet-explorer-11-does-not-add-the-origin-header-on-a-cors-request

gerritbot added a comment.May 30 2016, 10:19 AM

Change 291705 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace deprecated "edit" tokens with "csrf"

https://gerrit.wikimedia.org/r/291705

thiemowmde added projects: Wikidata-Sprint-2016-05-24, Wikibase-JavaScript-Api, MediaWiki-extensions-WikibaseView, MediaWiki-extensions-Wikibase-Repo.May 30 2016, 10:21 AM
thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-05-24 board.
gerritbot added a comment.May 30 2016, 11:01 AM

Change 291709 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix getLocationAgnosticMwApi behavior in Internet Explorer

https://gerrit.wikimedia.org/r/291709

Danny_B added a project: Browser-Support-Internet-Explorer.May 30 2016, 11:05 AM
Danny_B moved this task from Unsorted to IE11 on the Browser-Support-Internet-Explorer board.
Danny_B moved this task from IE11 to IE10 on the Browser-Support-Internet-Explorer board.
gerritbot added a comment.May 30 2016, 1:37 PM

Change 291705 merged by jenkins-bot:
Replace deprecated "options" tokens with "csrf"

https://gerrit.wikimedia.org/r/291705

JanZerebecki subscribed.May 30 2016, 1:43 PM

The documentation even mentions options as a valid token, it would be nice to update the docblock in core.

Luke081515 moved this task from incoming to in progress on the Wikidata board.May 30 2016, 2:22 PM
• Jonas added a comment.May 30 2016, 3:11 PM
In T136543#2338366, @thiemowmde wrote:

I believe this is not an issue we introduced in Wikibase, but something that changed in core.

Does the same error then also appear on wikipedia.org?

Lydia_Pintscher added a comment.May 30 2016, 3:27 PM

I also have at least one complaint from someone who got "forbidden" on Wikipedia when they were trying to add a sitelink from the client.

• Jonas added a subscriber: Krinkle.May 30 2016, 3:46 PM
gerritbot added a comment.May 30 2016, 4:07 PM

Change 291709 merged by jenkins-bot:
Fix getLocationAgnosticMwApi behavior in Internet Explorer

https://gerrit.wikimedia.org/r/291709

gerritbot added a comment.May 30 2016, 5:13 PM

Change 291769 had a related patch set uploaded (by JanZerebecki):
Fix getLocationAgnosticMwApi behavior in Internet Explorer

https://gerrit.wikimedia.org/r/291769

gerritbot added a comment.May 30 2016, 5:20 PM

Change 291769 merged by jenkins-bot:
Fix getLocationAgnosticMwApi behavior in Internet Explorer

https://gerrit.wikimedia.org/r/291769

gerritbot added a comment.May 30 2016, 5:29 PM

Change 291773 had a related patch set uploaded (by JanZerebecki):
Release 1.1.1

https://gerrit.wikimedia.org/r/291773

gerritbot added a comment.May 30 2016, 5:35 PM

Change 291773 merged by jenkins-bot:
Release 1.1.1

https://gerrit.wikimedia.org/r/291773

gerritbot added a comment.May 30 2016, 5:53 PM

Change 291774 had a related patch set uploaded (by JanZerebecki):
Update wikibase/javascript-api to 1.1.1

https://gerrit.wikimedia.org/r/291774

gerritbot added a comment.May 30 2016, 6:09 PM

Change 291774 merged by jenkins-bot:
Update wikibase/javascript-api to 1.1.1

https://gerrit.wikimedia.org/r/291774

Stashbot subscribed.May 30 2016, 6:14 PM

Mentioned in SAL [2016-05-30T18:14:06Z] Synchronized php-1.28.0-wmf.3/extensions/Wikidata/vendor/wikibase/javascript-api/src/getLocationAgnosticMwApi.js: Wikidata WikibaseJavaScriptApi: Fix getLocationAgnosticMwApi behavior in Internet Explorer b6ae82c71af3d9361cfb9e8d4e6e45bcd5ee9b26 1 of 2 T136543 (duration: 00m 26s)

Stashbot added a comment.May 30 2016, 6:15 PM

Mentioned in SAL [2016-05-30T18:15:47Z] Synchronized php-1.28.0-wmf.3/extensions/Wikidata/vendor/wikibase/javascript-api/WikibaseJavaScriptApi.php: Wikidata WikibaseJavaScriptApi: Fix getLocationAgnosticMwApi behavior in Internet Explorer b6ae82c71af3d9361cfb9e8d4e6e45bcd5ee9b26 2 of 2 T136543 (duration: 00m 24s)

JanZerebecki added a comment.May 30 2016, 7:12 PM

Editing labels on repo is now fixed in IE11.
It seems connecting a page on the client does not work on IE11, instead I get the new item special page on the repo.

JanZerebecki added a comment.May 30 2016, 7:20 PM

Editing on test and beta is broken in worse ways for IE11. Maybe because of outdated Gadgets?

• Jonas closed this task as Resolved.May 31 2016, 10:03 AM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-05-24 board.
gerritbot added a comment.May 31 2016, 10:24 AM

Change 291704 merged by jenkins-bot:
Release 2.0.0

https://gerrit.wikimedia.org/r/291704

thiemowmde added subscribers: aude, hoo.May 31 2016, 2:29 PM

I found the change that triggered this bug: https://gerrit.wikimedia.org/r/288510, merged on May 12, 4 days before the users started asking on the "contact the devs" page.

Strainu reopened this task as Open.May 31 2016, 5:08 PM
Strainu subscribed.

There is a report [1] that the issue is still reproducible for languages other than English, reopening.

[1] https://ro.wikipedia.org/wiki/Wikipedia:Cafenea#Probleme_cu_interfa.C8.9Ba

JanZerebecki added a comment.May 31 2016, 5:48 PM

*sigh* I can confirm what you said in IE11 (without logging in). That worked when I wrote T136543#2339545.
There is an error when clicking edit: Invalid Argument in the jQuery prop method called from createTag() in jquery.ui.tagadata.js . I'm not aware of a change since then.

JanZerebecki added a comment.May 31 2016, 6:08 PM

The error is only triggered when one of the labels is empty.

JanZerebecki added a comment.May 31 2016, 6:11 PM

The cause is .prop( 'dir', this.element.prop( 'dir' ) || 'auto' ); trying to set the dir property on the input field to auto which is not valid in IE11.

gerritbot added a comment.May 31 2016, 6:24 PM

Change 291960 had a related patch set uploaded (by JanZerebecki):
Work around IE not supporting dir=auto

https://gerrit.wikimedia.org/r/291960

gerritbot added a comment.May 31 2016, 6:43 PM

Change 291960 merged by jenkins-bot:
Work around IE not supporting dir=auto

https://gerrit.wikimedia.org/r/291960

gerritbot added a comment.May 31 2016, 7:12 PM

Change 291968 had a related patch set uploaded (by JanZerebecki):
Work around IE not supporting dir=auto

https://gerrit.wikimedia.org/r/291968

gerritbot added a comment.May 31 2016, 7:21 PM

Change 291968 merged by jenkins-bot:
Work around IE not supporting dir=auto

https://gerrit.wikimedia.org/r/291968

gerritbot added a comment.May 31 2016, 7:30 PM

Change 291973 had a related patch set uploaded (by JanZerebecki):
Update Wikibase

https://gerrit.wikimedia.org/r/291973

gerritbot added a comment.May 31 2016, 7:32 PM

Change 291973 abandoned by JanZerebecki:
Update Wikibase

Reason:
Wrong branch

https://gerrit.wikimedia.org/r/291973

gerritbot added a comment.May 31 2016, 7:32 PM

Change 291974 had a related patch set uploaded (by JanZerebecki):
Update Wikibase

https://gerrit.wikimedia.org/r/291974

gerritbot added a comment.May 31 2016, 8:28 PM

Change 291974 merged by jenkins-bot:
Update Wikibase

https://gerrit.wikimedia.org/r/291974

JanZerebecki closed this task as Resolved.May 31 2016, 8:39 PM
JanZerebecki claimed this task.
Nikerabbit mentioned this in T130390: Message group selector does not work in IE or Edge.Jun 1 2016, 5:44 AM
• Petar.petkovic removed a project: Patch-For-Review.Oct 6 2018, 4:04 PM
• Petar.petkovic removed subscribers: Stashbot, gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits