Page MenuHomePhabricator
Create Task
Maniphest T127056

[Story] Replace jquery.wikibase.toolbarcontroller by wikibase.view.ViewController
Closed, ResolvedPublic
Actions

Description

In T117689, we introduced ViewController, but it's unused now. All our views with edit mode should use it.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Switch entitytermsview to ControllerViewFactoryAdrian Heinemediawiki/extensions/Wikibasemaster+73 -192
Use of ViewController for editing in statementviewD3r1ck01mediawiki/extensions/Wikibasemaster+5 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

• adrianheine created this task.Feb 16 2016, 1:05 PM
• adrianheine raised the priority of this task from to Medium.
• adrianheine updated the task description. (Show Details)
• adrianheine added a project: Wikidata.
• adrianheine subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2016, 1:05 PM
• adrianheine added a subtask: T117689: [Task] Introduce ViewController for managing edit mode in referenceview.Feb 16 2016, 1:05 PM
• adrianheine added a subtask: T127055: [Task] Use ViewController for editing in statementview.
• adrianheine updated the task description. (Show Details)Feb 16 2016, 1:19 PM
• adrianheine set Security to None.
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Feb 18 2016, 12:23 PM
xSavitar claimed this task.Mar 3 2016, 8:10 AM
gerritbot subscribed.Mar 3 2016, 8:55 AM

Change 274654 had a related patch set uploaded (by D3r1ck01):
Use of ViewController for editing in statementview

https://gerrit.wikimedia.org/r/274654

gerritbot added a project: Patch-For-Review.Mar 3 2016, 8:55 AM
gerritbot added a comment.Mar 4 2016, 1:55 PM

Change 274654 abandoned by D3r1ck01:
Use of ViewController for editing in statementview

Reason:
To be worked on later

https://gerrit.wikimedia.org/r/274654

xSavitar removed xSavitar as the assignee of this task.Mar 4 2016, 1:56 PM
xSavitar subscribed.
xSavitar removed a project: Patch-For-Review.Mar 20 2016, 2:53 PM
• adrianheine added a project: Wikidata-Sprint-2016-05-10.May 10 2016, 10:25 AM
Danny_B added a project: Story.May 23 2016, 11:43 AM
gerritbot added a comment.Jul 28 2016, 11:27 AM

Change 298753 had a related patch set uploaded (by Adrian Heine):
Switch entitytermsview to ControllerViewFactory

https://gerrit.wikimedia.org/r/298753

gerritbot added a comment.Aug 9 2016, 10:49 AM

Change 298753 merged by jenkins-bot:
Switch entitytermsview to ControllerViewFactory

https://gerrit.wikimedia.org/r/298753

Lydia_Pintscher closed this task as Resolved.Aug 10 2016, 10:53 AM
Lydia_Pintscher claimed this task.
Lydia_Pintscher added a project: Wikidata-Sprint-2016-08-02.
Lydia_Pintscher moved this task from Proposed to Done on the Wikidata-Sprint-2016-08-02 board.
• Jonas closed subtask T127055: [Task] Use ViewController for editing in statementview as Resolved.Oct 12 2016, 8:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits