Repository navigation
Taint the array a foreach by reference writes into - #12121
Merged
Merged
Conversation
# Conflicts: # src/Psalm/Internal/Analyzer/Statements/Block/ForeachAnalyzer.php # tests/TaintTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What a
foreach (... as &$value)loop writes through$valuenow flows into the array it iterates over, so it isn't lost:The writes are taken from what
$valueholds at the end of an iteration and where the loop is left (break), and reach the array through an unkeyedarrayvalue-assignmentpath. When the array iterated over is a property, the property holds them too, so the taint reaches reads in other methods.Values overwritten before the iteration ends, and writes in a foreach by value, don't taint the array.