Skip to content

Fix master CI after merging 6.x - #12047

Merged
danog merged 1 commit into
vimeo:masterfrom
danog:fix-master-after-6x-merge
Sep 29, 2026
Merged

danog merged 1 commit into
vimeo:masterfrom
danog:fix-master-after-6x-merge

Conversation

@danog

@danog danog commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Fixes the CI failures on master after merging 6.x (895a33d):

  • Unit tests (PropertyTypeTest): the merge kept master's `$assign_var->class instanceof Name` restriction in `AssignmentAnalyzer`, dropping that part of Check $class::$prop reads and assignments when the class is a variable #12040, so `$class::$prop = ...` was again not analyzed. The restriction is removed.
  • Unit tests (AsymmetricVisibilityTest) / Psalm self-analysis: the new visibility check called `Properties::propertyExists()` with the 6.x signature. It now goes through `Codebase::propertyExists()`.
  • Self-analysis: `StaticPropertyFetchAnalyzer::getClassNamesFromClassStringType()` is marked `@psalm-capabilities read-props`.
  • PHPCS / stubs composer build: removed unused `md5` imports and sorted the use statements.
  • Windows unit tests (failing since Print the purity of closures and callables as Closure[pure] and callable[impure] #12042): two `PurityTemplateTest` expected messages hardcoded `src/somefile.php`; they now use `DIRECTORY_SEPARATOR`.

🤖 Generated with Claude Code

- Restore the removal of the `Name`-only restriction on static property
  assignments from vimeo#12040, which the merge dropped, so `$class::$prop = ...`
  is analyzed again
- Call Codebase::propertyExists(), since Properties::propertyExists() now
  takes the codebase as its first argument
- Mark getClassNamesFromClassStringType() as read-props
- Drop unused md5 imports and sort the use statements
- Use DIRECTORY_SEPARATOR in two PurityTemplateTest messages that failed on
  Windows

Co-Authored-By: Claude Opus 5.5 
@danog danog added the release:fix The PR will be included in 'Fixes' section of the release notes label Sep 29, 2026
@danog
danog merged commit 43d71cc into vimeo:master Sep 29, 2026
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:fix The PR will be included in 'Fixes' section of the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant