Repository navigation
[6.x] Accept --no-progress in psalm-refactor - #11995
Merged
Merged
Conversation
danog
added
the
release:feature
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #11812 (comment).
Refactor::run()already checks--no-progresswhen selecting its progress reporter, but the option was missing from its valid long options. Register it so getopt and argument validation accept it, and document it in the CLI help.Add an end-to-end regression asserting that
psalm-refactor --no-progress --helpexits successfully with no stderr instead of rejecting the flag.Created in a fresh worktree from freshly fetched upstream
6.xat7a3038794.Verification
php psalm-refactor --no-progress --help— passed.vendor/bin/phpunit tests/EndToEnd/PsalmEndToEndTest.php --filter testRefactorAcceptsNoProgressOption— passed (1 test, 2 assertions).vendor/bin/phpcs src/Psalm/Internal/Cli/Refactor.php tests/EndToEnd/PsalmEndToEndTest.php— passed.A full method-rename smoke attempt encountered a separate existing failure: configuration loading treats the symbol argument as a file path and exits with
Cannot locate .... That behavior is unchanged and outside this option-registration fix; regression coverage is limited to option acceptance.