Repository navigation
Fix problems caused by echo when the messages resembles some options or when "shopt -s xpg_echo" is set - #47
Merged
Merged
Conversation
Owner
|
Many thanks, I wasn' aware that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, we need to carefully use the builtin
echowhen the message can contain arbitrary strings.echobuiltin accepts options such as-n,-e, or--(actually the set of supported options differs between shells), which means that when the message text is confusing with these options,echobehaves in a unexpected way.shopt -s xpg_echoin.bashrcorset -o BSD_ECHOin.zshrc, the builtinechoprocesses backslashes in the message as an escape sequence, which would also cause unexpected behavior when the mark name,FZF_MARKS_FILE, or the directory paths contain backslashes.So, when the message can contain arbitrary strings, we can use the
printf '%s\n' ...idiom instead. Here is the fix.