Skip to content

Docs: 2.5.0 CM/MEC leftovers for #5630 - #5658

Merged
tig merged 1 commit into
developfrom
cursor/docs-250-cm-mec-leftovers-73a7
Sep 3, 2026
Merged

tig merged 1 commit into
developfrom
cursor/docs-250-cm-mec-leftovers-73a7

Conversation

@tig

@tig tig commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

I finished the Workstream 3 conceptual-docs leftovers on #5630. I did not touch GitVersion.yml, and I did not run Prepare Release.

Leftovers

  1. migratingfromv1.md: done. On develop, rg ConfigurationManager docfx/docs/migratingfromv1.md was empty. The leftover was a missing pointer, not leftover CM how-to. I added ## Configuration that tells v1 ConfigurationManager.Enable users to use TuiConfigurationBuilder and migrate-cm-to-mec.md. I did not rewrite the v1 history.

  2. 2.5.0 breaking-changes page: done. New page docfx/docs/breaking-changes-2.5.0.md is on the site via docfx/docs/toc.yml (2.5.0 Breaking Changes). Headings:

    • View.Text is no longer virtual.
    • IAcceptTarget moved to Terminal.Gui.Input.
    • ConfigurationManager and [ConfigurationProperty] removed.
    • config.json is nested only.
      Cross-links from config.md and newinv2.md. The GitHub Release notes list stays on Please Test v2.5 Beta! - breaking-change minor #5630.
  3. README versioning table: done. GitVersion.yml develop.increment is Patch. The table said Minor. I changed the Increment column to Patch, used 2.5.0-develop.55 as the example, and added a one-line note that +semver: minor is how you bump Minor. I did not change GitVersion.yml.

  4. Schemes.Resolve: done (was wrong). Schemes is an enum with no Resolve method (rg Resolve Terminal.Gui/Drawing/Schemes.cs is empty). The live API is SchemeManager.GetScheme. I changed the row in ai-v2-primer.md and llms.txt from Schemes.Resolve ("name") to SchemeManager.GetScheme ("name").

Hypothesis

Leftover CM advice was not in config.md (already rewritten with #5416). It was a missing MEC pointer in migratingfromv1.md, plus the README increment lie.

Out of scope

I left code and API behavior alone. I did not bump versions. I did not run Prepare Release.

Testing

Docs and primer only. Snippet CI should run because I touched ai-v2-primer.md and llms.txt.

Open in Web Open in Cursor 

Point v1 ConfigurationManager users at TuiConfigurationBuilder, add a
2.5.0 breaking-changes conceptual page, align the README develop
increment with GitVersion.yml Patch, and correct Schemes.Resolve to
SchemeManager.GetScheme in the primer and llms.txt.

Co-authored-by: Tig 
@tig
tig marked this pull request as ready for review September 3, 2026 12:47
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-03T12:51:50.126795Z 8b74a80 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tig

tig commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Reviewed. WS3 leftovers look covered:

  • migratingfromv1 now points v1 ConfigurationManager.Enable at TuiConfigurationBuilder / migrate-cm-to-mec.md without rewriting the v1 history
  • conceptual breaking-changes-2.5.0.md is on the toc and linked from config.md / newinv2.md
  • README develop increment matches GitVersion.yml Patch; +semver: minor note is right
  • primer/llms.txt Schemes.Resolve → SchemeManager.GetScheme is a real API fix, not a no-op

Do not merge until snippet/lint CI is green. Left the README “MAJOR for breaking changes” product sentence alone (that is the 3.0.0 debate, out of scope here).

@tig
tig merged commit 2e5c2dd into develop Sep 3, 2026
15 checks passed
@tig
tig deleted the cursor/docs-250-cm-mec-leftovers-73a7 branch September 3, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants