Repository navigation
Docs: 2.5.0 CM/MEC leftovers for #5630 - #5658
Merged
Merged
Conversation
Point v1 ConfigurationManager users at TuiConfigurationBuilder, add a 2.5.0 breaking-changes conceptual page, align the README develop increment with GitVersion.yml Patch, and correct Schemes.Resolve to SchemeManager.GetScheme in the primer and llms.txt. Co-authored-by: Tig
tig
marked this pull request as ready for review
September 3, 2026 12:47
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
Reviewed. WS3 leftovers look covered:
Do not merge until snippet/lint CI is green. Left the README “MAJOR for breaking changes” product sentence alone (that is the 3.0.0 debate, out of scope here). |
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I finished the Workstream 3 conceptual-docs leftovers on #5630. I did not touch
GitVersion.yml, and I did not run Prepare Release.Leftovers
migratingfromv1.md: done. On develop,
rg ConfigurationManager docfx/docs/migratingfromv1.mdwas empty. The leftover was a missing pointer, not leftover CM how-to. I added## Configurationthat tells v1ConfigurationManager.Enableusers to useTuiConfigurationBuilderand migrate-cm-to-mec.md. I did not rewrite the v1 history.2.5.0 breaking-changes page: done. New page docfx/docs/breaking-changes-2.5.0.md is on the site via
docfx/docs/toc.yml(2.5.0 Breaking Changes). Headings:View.Textis no longer virtual.IAcceptTargetmoved toTerminal.Gui.Input.ConfigurationManagerand[ConfigurationProperty]removed.config.jsonis nested only.Cross-links from
config.mdandnewinv2.md. The GitHub Release notes list stays on Please Test v2.5 Beta! - breaking-change minor #5630.README versioning table: done.
GitVersion.ymldevelop.incrementisPatch. The table saidMinor. I changed the Increment column to Patch, used2.5.0-develop.55as the example, and added a one-line note that+semver: minoris how you bump Minor. I did not changeGitVersion.yml.Schemes.Resolve: done (was wrong).
Schemesis an enum with noResolvemethod (rg Resolve Terminal.Gui/Drawing/Schemes.csis empty). The live API isSchemeManager.GetScheme. I changed the row inai-v2-primer.mdandllms.txtfromSchemes.Resolve ("name")toSchemeManager.GetScheme ("name").Hypothesis
Leftover CM advice was not in
config.md(already rewritten with #5416). It was a missing MEC pointer inmigratingfromv1.md, plus the README increment lie.Out of scope
I left code and API behavior alone. I did not bump versions. I did not run Prepare Release.
Testing
Docs and primer only. Snippet CI should run because I touched
ai-v2-primer.mdandllms.txt.