Skip to content

Rename internal references: gui-cs → tui-cs - #5528

Merged
tig merged 3 commits into
developfrom
tig/rename-gui-cs-to-tui-cs
Jun 23, 2026
Merged

tig merged 3 commits into
developfrom
tig/rename-gui-cs-to-tui-cs

Conversation

@tig

@tig tig commented Jun 23, 2026

Copy link
Copy Markdown
Member

Closes #5526.

Part of the org-wide rename gui-cs → tui-cs. GitHub auto-redirects all github.com/gui-cs/* URLs, so this only updates internal references so the repo is self-consistent.

What changed

134 files. Mechanical rule: every gui-cs (hyphen — the org login) → tui-cs. The historical brand gui.cs (dot) is intentionally left as-is (prose, sample text, test data).

Notable / non-mechanical spots (reviewed by hand)

  • Schema URL default — SettingsScope.Schema + Resources/config.json $schema → https://tui-cs.github.io/Terminal.Gui/schemas/tui-config-schema.json. Not fetched at runtime (editor/IntelliSense hint), so old in-the-wild configs are cosmetically affected only.
  • Workflows (functional) — repository_dispatch targets clet, Terminal.Gui.templates, Editor, and the go install github.com/.../tuirec path → tui-cs. Secrets/PATs unchanged.
  • Link.cs default URL + coupled LinkTests assertions kept consistent (same string length, so TextViewTests URL-truncation cases are unaffected).
  • Left untouched: Terminal.sln.DotSettings — its only hit is a machine-specific absolute path (C:\Users\Tig\s\gui-cs\…), not a public reference.

⚠️ Merge sequencing — DRAFT until after the rename

This is prep-first. The new tui-cs.github.io URLs and the cross-repo dispatch targets only resolve after the org is renamed and the dependent repos (clet, Editor, Terminal.Gui.templates, tuirec) move. Do not merge before the rename.

Master plan: tui-cs-rename-master-plan.md (local coordination doc).

Org rename gui-cs → tui-cs. GitHub auto-redirects all github.com/gui-cs/*
URLs, but this updates internal references so the repo is self-consistent.

Mechanical: every `gui-cs` (hyphen, the org login) → `tui-cs`. The historical
brand `gui.cs` (dot) is intentionally left as-is (prose/test data/sample text).

Notable:
- Schema default (SettingsScope.Schema) + Resources/config.json $schema →
  https://tui-cs.github.io/Terminal.Gui/schemas/tui-config-schema.json
- Workflow cross-repo repository_dispatch targets (clet, Terminal.Gui.templates,
  Editor) and the tuirec `go install` path → tui-cs. These resolve once the org
  rename + those repos' moves land, so merge AFTER the rename.
- Link.cs default URL + coupled LinkTests assertions kept consistent.
- Terminal.sln.DotSettings left untouched: its only hit is a machine-specific
  absolute path (C:\Users\Tig\s\gui-cs\...), not a public reference.

Part of the org-wide gui-cs → tui-cs rename.

Co-Authored-By: Claude Opus 4.8 (1M context) 
@tig
tig marked this pull request as ready for review June 23, 2026 16:59
WordBackward_WordWrap_False_True truncates the $schema URL mid-token at
word boundaries. Four expected-string fragments cut the URL before the `cs`
(`https://gui-`, `https://gui`), so the `gui-cs`→`tui-cs` pass didn't match
them and they stayed `gui` while the (renamed) input produces `tui`.
Update the four fragments to `https://tui-` / `https://tui`.

Co-Authored-By: Claude Opus 4.8 (1M context) 

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 664f49b706

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/api-docs.yml Outdated
if: steps.view-docs.outputs.should_generate == 'true'
run: |
go install github.com/gui-cs/tuirec/cmd/tuirec@latest
go install github.com/tui-cs/tuirec/cmd/tuirec@latest

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep tuirec install path on declared Go module

This commit also changes docfx/scripts/generate-views-doc.ps1, so Detect view docs changes sets should_generate=true and this go install ...@latest line runs on the API-docs workflow. The current tui-cs/tuirec repository still declares module github.com/gui-cs/tuirec in go.mod; with an @latest argument, go install treats this as the import path to resolve and rejects a module whose declared path does not match, so the docs workflow cannot regenerate/deploy. Keep installing github.com/gui-cs/tuirec/cmd/tuirec@latest until tuirec's module path is changed.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — resolved in 2e9c666, though via a different route than suggested.

Pinning the install back to gui-cs/tuirec@latest would work only until tuirec cuts a release carrying the new module path, then it'd break the other way. Instead I pinned to @main:

go install github.com/tui-cs/tuirec/cmd/tuirec@main

tuirec's main already declares module github.com/tui-cs/tuirec (the rename PR is merged), so the import-path check passes now and stays correct after future tags. The released tags (≤ v0.9.0) still declare gui-cs, which is exactly why @latest failed.

go install github.com/tui-cs/tuirec/cmd/tuirec@latest resolves to tuirec's
latest semver tag (v0.9.0), whose go.mod still declares the old module path
github.com/gui-cs/tuirec — so the import-path check fails. tuirec's main
already declares github.com/tui-cs/tuirec, so pin to @main.

Co-Authored-By: Claude Opus 4.8 (1M context) 
@tig
tig merged commit 7fedcf5 into develop Jun 23, 2026
20 of 21 checks passed
@tig
tig deleted the tig/rename-gui-cs-to-tui-cs branch June 23, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename: update internal gui-cs → tui-cs references

1 participant