Skip to content

Fix refresh token int user ID - #1436

Merged
Sephster merged 4 commits into
thephpleague:masterfrom
ssigwart:intUserId
Nov 14, 2024
Merged

Sephster merged 4 commits into
thephpleague:masterfrom
ssigwart:intUserId

Conversation

@ssigwart

@ssigwart ssigwart commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

Fixes #1435

Old refresh tokens may have int user IDs causing an exception. This fixes that.

@Sephster Sephster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Thank you for your PR. Looks like this will do the job. Apologies I didn't notice this when releasing v9

Comment thread src/Grant/RefreshTokenGrant.php

@ssigwart ssigwart left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Thank you for your PR. Looks like this will do the job. Apologies I didn't notice this when releasing v9

No problem. Thanks for working on this project.

Comment thread src/Grant/RefreshTokenGrant.php
@Sephster
Sephster merged commit fe04ef2 into thephpleague:master Nov 14, 2024
@ssigwart
ssigwart deleted the intUserId branch November 16, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v9 Typing breaks existing refresh tokens

4 participants