Skip to content

fix(push): fixes push notifications not showing (#100) - #107

Merged
sidneys merged 1 commit into
sidneys:masterfrom
btaens:push-notifications-fix
Nov 14, 2019
Merged

sidneys merged 1 commit into
sidneys:masterfrom
btaens:push-notifications-fix

Conversation

@btaens

@btaens btaens commented Jul 24, 2019 •

Copy link
Copy Markdown
Contributor

📋 Description

Fixes push notifications not showing on any desktops by checking whether target has image_url when retrieving iconChat, avoiding an exception thrown as described in #100.

🗂 Type

  • 🍾 Feature
  • 🚨 Bugfix
  • 📒 Documentation
  • 👷 Internals

🔥 Severity

  • 💎 Non-Breaking Changes
  • 💔 Breaking Changes

🖥 Platforms

  • 🍏 macOS
  • 💾 Windows
  • 🐧 Linux

🛃 Tests

  • My changes have been tested manually.
  • My changes are covered by automated testing methods.

👨‍🎓 Miscellaneous

  • My changes follow the style guide.
  • My changes require updates to the documentation.

@sidneys

sidneys commented Nov 14, 2019

Copy link
Copy Markdown
Owner

@btaens Thank you, this will be in the next release as well.

@sidneys sidneys closed this Nov 14, 2019
@sidneys sidneys reopened this Nov 14, 2019
@sidneys
sidneys merged commit 3b92d4a into sidneys:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants