Skip to content

lint: unit test improvements - #674

Merged
samber merged 10 commits into
samber:masterfrom
NathanBaulch:unittests
Sep 24, 2025
Merged

samber merged 10 commits into
samber:masterfrom
NathanBaulch:unittests

Conversation

@NathanBaulch

Copy link
Copy Markdown
Contributor

Various unit test improvements that weren't caught by the recent introduction of the testifylint linter, discovered during my work on #672. Each commit addresses a different issue. These can be squash merged in their entirety or I can create more specific individual PRs if preferred.

@codecov

codecov Bot commented Sep 24, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.49%. Comparing base (3bc887c) to head (52f618b).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files          18       18           
  Lines        3305     3305           
=======================================
  Hits         3123     3123           
  Misses        170      170           
  Partials       12       12           
Flag Coverage Δ
unittests 94.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samber
samber merged commit 7170719 into samber:master Sep 24, 2025
8 of 9 checks passed
@NathanBaulch
NathanBaulch deleted the unittests branch September 24, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants