Skip to content

feat: add WaitForWithContext - #480

Merged
samber merged 5 commits into
samber:masterfrom
ccoveille-forks:waitfor
Jul 15, 2024
Merged

feat: add WaitForWithContext#480
samber merged 5 commits into
samber:masterfrom
ccoveille-forks:waitfor

Conversation

@ccoVeille

@ccoVeille ccoVeille commented Jun 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@ccoVeille ccoVeille mentioned this pull request Jun 29, 2024
Merged
@ccoVeille

ccoVeille commented Jun 29, 2024

Copy link
Copy Markdown
Contributor Author

Please review, you will tell me if it's OK for you

I didn't check if you had other method that could be improved by having a context. Let me know, and I can add method if you want

samber
samber reviewed Jun 30, 2024
View reviewed changes
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
samber
samber reviewed Jun 30, 2024
View reviewed changes
Comment thread concurrency.go Outdated
@ccoVeille

ccoVeille commented Jun 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I neex to add test to validate the context passed to condition is canceled

@ccoVeille
ccoVeille marked this pull request as draft June 30, 2024 09:50
ccoVeille
ccoVeille commented Jun 30, 2024
View reviewed changes
Comment thread concurrency.go Outdated
Comment thread concurrency.go Outdated
ccoVeille
ccoVeille commented Jun 30, 2024
View reviewed changes
Comment thread concurrency.go Outdated
ccoVeille added 3 commits July 3, 2024 00:04
@ccoVeille
chore: fix test timeout helper
2cce8d8 
using os.Exit(1) kills everything, tests statuses are not always displayed
@ccoVeille
chore: refactor WaitFor unit tests
e26f1b4 
zero-code changes
@ccoVeille
fix: WaitFor on first condition
071a746 
duration must be non-zero if first conditions is true
@ccoVeille
ccoVeille marked this pull request as ready for review July 2, 2024 22:44
@ccoVeille
ccoVeille requested a review from samber July 2, 2024 22:45
@ccoVeille

ccoVeille commented Jul 13, 2024

Copy link
Copy Markdown
Contributor Author

@samber ?

@samber

samber commented Jul 15, 2024

Copy link
Copy Markdown
Owner

Sorry for the delay. Let's merge ;)

@samber
samber merged commit 0f4679b into samber:master Jul 15, 2024
@ccoVeille
ccoVeille deleted the waitfor branch July 15, 2024 17:34
@ccoVeille

ccoVeille commented Jul 15, 2024

Copy link
Copy Markdown
Contributor Author

Thanks

github-actions Bot referenced this pull request in kairos-io/provider-kairos Jul 15, 2024
@renovate
fix(deps): update module github.com/samber/lo to v1.46.0 (#604)
8bdabec 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.45.0` ->
`v1.46.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.45.0/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.45.0/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes



samber/lo (github.com/samber/lo)

### [`v1.46.0`](https://togithub.com/samber/lo/releases/tag/v1.46.0)

[Compare
Source](https://togithub.com/samber/lo/compare/v1.45.0...v1.46.0)

#### What's Changed

- fix: chunk memory leak, bug fix by
[@​mihir20](https://togithub.com/mihir20) in
[https://github.com/samber/lo/pull/491](https://togithub.com/samber/lo/pull/491)
- feat: add WaitForWithContext by
[@​ccoVeille](https://togithub.com/ccoVeille) in
[https://github.com/samber/lo/pull/480](https://togithub.com/samber/lo/pull/480)
- add ForEachCondition implement by
[@​Sianao](https://togithub.com/Sianao) in
[https://github.com/samber/lo/pull/485](https://togithub.com/samber/lo/pull/485)

#### New Contributors

- [@​mihir20](https://togithub.com/mihir20) made their first
contribution in
[https://github.com/samber/lo/pull/491](https://togithub.com/samber/lo/pull/491)
- [@​ccoVeille](https://togithub.com/ccoVeille) made their first
contribution in
[https://github.com/samber/lo/pull/480](https://togithub.com/samber/lo/pull/480)
- [@​Sianao](https://togithub.com/Sianao) made their first
contribution in
[https://github.com/samber/lo/pull/485](https://togithub.com/samber/lo/pull/485)

**Full Changelog**:
samber/lo@v1.45.0...v1.46.0




---

### Configuration

📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kairos-io/provider-kairos).



Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten referenced this pull request in open-telemetry/opentelemetry-collector-contrib Jul 17, 2024
@renovate @opentelemetrybot @songy23
Update module github.com/samber/lo to v1.46.0 (#34113)
892692a 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.44.0` ->
`v1.46.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.44.0/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.44.0/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes



samber/lo (github.com/samber/lo)

### [`v1.46.0`](https://togithub.com/samber/lo/releases/tag/v1.46.0)

[Compare
Source](https://togithub.com/samber/lo/compare/v1.45.0...v1.46.0)

#### What's Changed

- fix: chunk memory leak, bug fix by
[@&#8203;mihir20](https://togithub.com/mihir20) in
[https://github.com/samber/lo/pull/491](https://togithub.com/samber/lo/pull/491)
- feat: add WaitForWithContext by
[@&#8203;ccoVeille](https://togithub.com/ccoVeille) in
[https://github.com/samber/lo/pull/480](https://togithub.com/samber/lo/pull/480)
- add ForEachCondition implement by
[@&#8203;Sianao](https://togithub.com/Sianao) in
[https://github.com/samber/lo/pull/485](https://togithub.com/samber/lo/pull/485)

#### New Contributors

- [@&#8203;mihir20](https://togithub.com/mihir20) made their first
contribution in
[https://github.com/samber/lo/pull/491](https://togithub.com/samber/lo/pull/491)
- [@&#8203;ccoVeille](https://togithub.com/ccoVeille) made their first
contribution in
[https://github.com/samber/lo/pull/480](https://togithub.com/samber/lo/pull/480)
- [@&#8203;Sianao](https://togithub.com/Sianao) made their first
contribution in
[https://github.com/samber/lo/pull/485](https://togithub.com/samber/lo/pull/485)

**Full Changelog**:
samber/lo@v1.45.0...v1.46.0

### [`v1.45.0`](https://togithub.com/samber/lo/releases/tag/v1.45.0)

[Compare
Source](https://togithub.com/samber/lo/compare/v1.44.0...v1.45.0)

#### What's Changed

- perf: preallocate in Assign by
[@&#8203;pmalek](https://togithub.com/pmalek) in
[https://github.com/samber/lo/pull/484](https://togithub.com/samber/lo/pull/484)
- feat: adding EarliestBy and LatestBy functions by
[@&#8203;timych](https://togithub.com/timych) in
[https://github.com/samber/lo/pull/489](https://togithub.com/samber/lo/pull/489)

#### New Contributors

- [@&#8203;pmalek](https://togithub.com/pmalek) made their first
contribution in
[https://github.com/samber/lo/pull/484](https://togithub.com/samber/lo/pull/484)
- [@&#8203;timych](https://togithub.com/timych) made their first
contribution in
[https://github.com/samber/lo/pull/489](https://togithub.com/samber/lo/pull/489)

**Full Changelog**:
samber/lo@v1.44.0...v1.45.0




---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).



---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Yang Song
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samber samber samber approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ccoVeille @samber