Repository navigation
feat(observable-events): add provider-aware event generator - #150
Merged
Merged
Conversation
Generator: - add incremental instance and static event observable generation - select lean Primitives, Reactive Primitives, or standalone System.Reactive from consumer references - ship RXOE001-RXOE003 release metadata for 7.2.0 Compatibility: - cover WPF, WinForms, Avalonia, MAUI, and async event delegates - document package installation, payload mapping, and static generation - wire the analyzer and tests into the solution Testing: - add TUnit Roslyn compilation coverage for provider, generic, collision, platform, and async cases - retain 100 percent line and branch coverage for the generator
ChrisPulman
marked this pull request as ready for review
August 12, 2026 22:52
Dependencies: - Bind the analyzer to System.Collections.Immutable 9.0.0, the Roslyn 4.14 minimum. - Keep the dependency private so the analyzer-only package remains dependency-free. Validation: - Pass the net9 ObservableEvents TUnit suite. - Preserve 100% generator line and branch coverage.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 98.10% 98.14% +0.03%
==========================================
Files 678 679 +1
Lines 21004 21417 +413
Branches 2533 2619 +86
==========================================
+ Hits 20606 21019 +413
Misses 197 197
Partials 201 201 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
glennawatson
approved these changes
Aug 15, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A new provider-aware incremental source generator package for exposing .NET events as strongly typed observables, with documentation and compatibility tests.
What is the new behavior?
ReactiveUI.Primitives.ObservableEventsas an analyzer-onlynetstandard2.0package.Events()calls and static event observables throughGenerateStaticEventObservablesAttribute.ReactiveUI.Primitives,ReactiveUI.Primitives.Reactive, or standaloneSystem.ReactiveAPIs from the consuming compilation without adding a runtime dependency.void,Task, andValueTaskevent delegates, inherited events, generic/nested hosts, and collision-safe generated names.RXOE001throughRXOE003inAnalyzerReleases.Shipped.mdfor release 7.2.0.AnalyzerReleases.Unshipped.mdcontains only#nullable enable; the project excludes that marker from Roslyn's Markdown release parser while continuing to validate the shipped table.What is the current behavior?
There is no ObservableEvents analyzer package in this repository, so consumers must adapt .NET events manually or depend on a separate generator that is tied to System.Reactive APIs.
Checklist
Additional information
Validation completed locally:
net10.0-windows.analyzers/dotnet/cs, with no runtime dependency group.