Skip to content

Fix honoring "throttle.min_peers*" settings in rtorrent - #169

Merged
rakshasa merged 1 commit into
rakshasa:masterfrom
chros73:fix_min_peers_settings
Jun 9, 2019
Merged

rakshasa merged 1 commit into
rakshasa:masterfrom
chros73:fix_min_peers_settings

Conversation

@chros73

@chros73 chros73 commented May 13, 2018 •

Copy link
Copy Markdown

Fix honoring throttle.min_peers.normal and throttle.min_peers.seed settings in rtorrent:

Due to this bug, handling interval of announce tracker request is broken:

  • it never use interval but min interval instead

Required behavior:

  • it will use tracker interval if:
    • the client has more than min_peers - (peer_list_size / 2) connections for a download
    • or Peer Exchange is enabled and gives connections for a download
  • it will use tracker min interval otherwise:
    • the client has less than min_peers - (peer_list_size / 2) connections for a download and Peer Exchange isn't enabled

Default values for throttle.min_peers* settings: 100

Fixes: #167, rakshasa/rtorrent#386
Refers to: #168

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 18.027% when pulling ee8d5be on chros73:fix_min_peers_settings into c167c5a on rakshasa:master.

@chros73 chros73 mentioned this pull request May 13, 2018
@rakshasa
rakshasa merged commit ee8d5be into rakshasa:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

min interval is ignored

3 participants