Skip to content

Use the correct JSON Schema mode when handling function schemas - #11367

Merged
Viicos merged 1 commit into
mainfrom
json-schema-mode
Feb 1, 2025
Merged

Viicos merged 1 commit into
mainfrom
json-schema-mode

Conversation

@Viicos

@Viicos Viicos commented Jan 30, 2025

Copy link
Copy Markdown
Member

Change Summary

The mode property accounts for the json_schema_mode_override configuration value.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Jan 30, 2025
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8953aa9
Status: ✅  Deploy successful!
Preview URL: https://238e7152.pydantic-docs.pages.dev
Branch Preview URL: https://json-schema-mode.pydantic-docs.pages.dev

View logs

@codspeed

codspeed Bot commented Jan 30, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #11367 will not alter performance

Comparing json-schema-mode (8953aa9) with main (5e36892)

Summary

✅ 45 untouched benchmarks

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  json_schema.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos
Viicos merged commit be26201 into main Feb 1, 2025
@Viicos
Viicos deleted the json-schema-mode branch February 1, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants