Repository navigation
Remove custom MRO implementation of Pydantic models - #11184
Conversation
This is no longer necessary since #10666 was introduced.
Deploying pydantic-docs with
|
| Latest commit: |
6adc9c3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6df86b72.pydantic-docs.pages.dev |
| Branch Preview URL: | https://revert-mro.pydantic-docs.pages.dev |
|
I believe this should be backported, as it fixes #11042 which was a regression. |
|
Generally, I approve of this approach, as discussed in #10666. I think that the less we can manipulate the MRO, the better, as it introduces a pretty complex internal pattern that's hard to maintain. That being said, I think we should get buy in from @kc0506 and @dmontagu, as they were pretty involved in the addition of this custom MRO implementation. Happy to do another patch 2.10 release with this fix, I've added the corresponding label. |
CodSpeed Performance ReportMerging #11184 will not alter performanceComparing Summary
|
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sydney-runkle
left a comment
There was a problem hiding this comment.
Reviewed again, given that this is basically just a reversion, I think we can go ahead and merge.
This is no longer necessary since #10666 was introduced.
Fixes #11183.
Fixes #11042.
Closes #11037.
Change Summary
Related issue number
Checklist