Repository navigation
Use correct types namespace when building namedtuple core schemas - #10337
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
61ef3dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://801cbc02.pydantic-docs.pages.dev |
| Branch Preview URL: | https://10336.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10337 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Great find @Viicos. Do we need to make any changed to typed dicts (I see we also changed that schema gen func in the original PR)
Feel free to remove that benchmark for now (let's comment it out), it's too flaky to be valuable at this point.
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
The types namespace stack is updated for typeddicts but wasn't for namedtuples, so this only affected the latter. |
I have a pending PR that I'll finish this afternoon to tackle this |
|
Sounds good. Also, could you please add a test before we merge? |
Change Summary
Fixes #10336
Regression introduced in #10063
See diff without whitespaces
Related issue number
Checklist