Repository navigation
Optimize curve25519 field element by removing array - #198
Merged
Merged
Conversation
By leveraging PHP's optimized object key access for what is effectively always a fixed-length array, we can remove some computational overhead and memory usage in by the PHP interpreter. Since these memory access patterns are not secret (they were array indices from 0 to 9), the risk of side-channel leakage by this change is at least as low as what was previously implemented.
paragonie-security
added a commit
that referenced
this pull request
Oct 4, 2025
By leveraging PHP's optimized object key access for what is effectively always a fixed-length array, we can remove some computational overhead and memory usage in by the PHP interpreter. Since these memory access patterns are not secret (they were array indices from 0 to 9), the risk of side-channel leakage by this change is at least as low as what was previously implemented. This is a backport of #198 to the v1.x branch. It's not a 1:1 copy, as some code style changes occur in PHP 8.1+.
Merged
Contributor
Author
|
The performance results from #199 are also telling:
|
paragonie-security
added a commit
that referenced
this pull request
Oct 4, 2025
Backport #198 to v1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By leveraging PHP's optimized object key access for what is effectively always a fixed-length array, we can remove some computational overhead and memory usage in by the PHP interpreter.
Since these memory access patterns are not secret (they were array indices from 0 to 9), the risk of side-channel leakage by this change is at least as low as what was previously implemented.
Unit Test Suite Runtime Ccomparison
I need to backport this change to v1.x and see if we get similar performance wins from the same strategy there (without sacrificing PHP 5.2 support) before I merge this pull request.