Repository navigation
Add Cardzone Group, and the Brands it operates #9785
Description
According to their website, Cardzone Ltd. owns/operates 141 stores across the UK under the following brands:
- Cardzone (60 stores)
- Mooch (18 stores)
- Paper Kisses (17 stores)
- Hallmark (20 stores)
- Yankee Candle (12 stores)
- Card Centre (14 stores)
Of these, only Hallmark and Yankee Candles have entries in the NSI.
Activity
ClarSco commentedon Aug 10, 2024
Relevant Wikidata Items:
Relevant Wikipedia articles:
Snowysauce commentedon Aug 11, 2024
I've opened a pull request to add the Cardzone brand to NSI as it easily meets the suggested inclusion criteria. As you mentioned, Hallmark and Yankee Candle are already in the NSI, and both are also already available for tagging in the UK.
That leaves the Mooch, Paper Kisses, and Card Centre brands, which may not have enough locations to be included in the NSI. I'll defer to the opinions of the more established maintainers when it comes to that topic.
As for Cardzone Group (the operator), adding it to the NSI in such a way that would address this issue would require (to my knowledge) adding two new categories that don't currently exist in the code:
operators/shop/giftandoperators/shop/candles. Again, I'll defer to the opinions of the more established maintainers as to whether these should be added (and whether my understanding of the code is correct).bhousel commentedon Aug 13, 2024
This sounds like it would cause the same issues as #9716
If we already have these as brands we shouldn't also have an entry under the operators tree for "Cardzone Group" as the operator.
Snowysauce commentedon Aug 14, 2024
If I'm interpreting the comments at #9716 correctly, the plugins/editors using the NSI prioritize matching for brands prior to matching for operators, and only attempt to match for operators if there were no matching brands? It makes sense and I agree that this is the correct prioritization, but I didn't know that. For the OP, I guess that leaves three options:
Notes for the OP on option 2: either the Cardzone brand or the Cardzone Group operator would need a separate Wikidata item from Q123019897 as the
npmoperations used to build the NSI will produce a warning if the same QID is used in both the brand and operator trees in the same category (e.g.,brands/shop/giftandoperators/shop/gift).bhousel commentedon Aug 14, 2024
Sort of - yes the matching behavior is kind of confusing and the code is simpler than people think.
I think people believe that the code works like:
"If I see
name=HallmarkI can suggestbrand:wikidata=Q1521910AND if I see
operator=CardzoneI can suggestoperator:wikidata=Q123019897"The problem is that there is no ability to do AND, or chain rules together like that.
It just does one tag match and suggests more correct tags based on that.
So, if all the Hallmarks really are operated by Cardzone, you can just add those tags to the existing
brand/shop/gift.jsonHallmark item.Operator is also tricky in OSM for brands that operate under the franchise model. So I don't know whether all Hallmarks really are operated by Cardzone, or whether they are operated by franchisees.
In any case..
brand=Hallmarkandbrand:wikidata=Q1521910is extremely useful to tie all the Hallmarks together under that common brand, and gives data consumers a link to Wikidata where they can find out all kinds of other information about Hallmark (maybe including their business connection to Cardzone)operator=Cardzoneandoperator:wikidata=Q123019897on each Hallmark is.. Maybe interesting to someone? Probably not wrong? I've never understood who cares about this tag.UKChris-osm commentedon Aug 17, 2024
I don't think we need to worry about the
operatorin this case at all, and focus purely on thebrandsindividually. I'd be happy for the remaining three brands to be added as they are, as while they may not have a large number of stores, I think they still have enough value in them to be added individually, and more stores may be opened at a later date.Added Mooch to gift.json
Added Paper Kisses to gift.json
Added Card Centre to gift.json