Repository navigation
Check UPS mail drop boxes #4866
Description
I'm feeling mostly good about how mail boxes look in NSI v5, except for UPS.
UPS looks weird because we use a template to expand all of the post offices into mail drop locations. The post office is branded/named/operated by "The UPS Store" (fine) but the mail drop boxes really should just be branded/named/operated by "UPS" (which has a different QID from the UPS Store).
I was hoping to avoid this, but it looks like I need to figure out a way to make the templates slightly smarter. We need a way of saying which items to not expand from the templateSource. 😓
name-suggestion-index/data/operators/amenity/post_box.json
Lines 2 to 10 in d779cfb
Activity
tas50 commentedon Jan 19, 2021
I just came here to report this one. It's going to cause a lot of issues since iD is suggesting updating actual UPS mailboxes to be UPS Store mailboxes.
bhousel commentedon Jan 19, 2021
I did this! Template items now support include/exclude patterns that will match against the ids.
I added an exclude for the "upsstore" post office and created an item for "UPS" operated mail boxes: