Skip to content

deb.am: propagate build errors in native-deb targets - #18424

Merged
behlendorf merged 1 commit into
openzfs:masterfrom
chrislongros:fix/deb-am-error-propagation
Apr 15, 2026
Merged

deb.am: propagate build errors in native-deb targets#18424
behlendorf merged 1 commit into
openzfs:masterfrom
chrislongros:fix/deb-am-error-propagation

Conversation

@chrislongros

@chrislongros chrislongros commented Apr 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Replace ; with && in native-deb-utils and native-deb-kmod targets
    so that build failures propagate to make
  • Use trap ... EXIT for lockfile cleanup so it runs on both success and failure

Testing

Tested on Debian 12 (bookworm) VM, kernel 6.1.0-44-amd64:

  • make native-deb-utils builds all .deb packages successfully
  • Simulated dpkg-buildpackage failure: old code exits 0 (bug), new code exits non-zero (fixed)
  • Lockfile cleaned up on both success and failure

Fixes #18206

@tonyhutter

tonyhutter commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

I'd recommend re-basing on master. That will pull in 74da516, which may fix your out of disk space CI issues.

@chrislongros
deb.am: propagate build errors in native-deb targets
7ef8645 
Replace semicolons with && so build failures are not masked by the
subsequent lockfile cleanup.  Use trap to ensure the lockfile is
removed on both success and failure.

Fixes openzfs#18206

Signed-off-by: Christos Longros
@chrislongros
chrislongros force-pushed the fix/deb-am-error-propagation branch from e42327b to 7ef8645 Compare April 14, 2026 18:40
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Apr 15, 2026
@behlendorf
behlendorf merged commit 4b4ae48 into openzfs:master Apr 15, 2026
37 of 42 checks passed
Rudd-O pushed a commit to Rudd-O/zfs that referenced this pull request Apr 23, 2026
@chrislongros @Rudd-O
deb.am: propagate build errors in native-deb targets
2132e4f 
Replace semicolons with && so build failures are not masked by the
subsequent lockfile cleanup.  Use trap to ensure the lockfile is
removed on both success and failure.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Christos Longros 
Closes openzfs#18206
Closes openzfs#18424
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@chrislongros @tonyhutter
deb.am: propagate build errors in native-deb targets
64e137c 
Replace semicolons with && so build failures are not masked by the
subsequent lockfile cleanup.  Use trap to ensure the lockfile is
removed on both success and failure.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Christos Longros 
Closes #18206
Closes #18424
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@chrislongros @tonyhutter
deb.am: propagate build errors in native-deb targets
a6b3ff9 
Replace semicolons with && so build failures are not masked by the
subsequent lockfile cleanup.  Use trap to ensure the lockfile is
removed on both success and failure.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Christos Longros 
Closes #18206
Closes #18424
@chrislongros
chrislongros deleted the fix/deb-am-error-propagation branch June 6, 2026 13:17
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Jul 30, 2026
@chrislongros @lundman
deb.am: propagate build errors in native-deb targets
d20ad3d 
Replace semicolons with && so build failures are not masked by the
subsequent lockfile cleanup.  Use trap to ensure the lockfile is
removed on both success and failure.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Christos Longros 
Closes openzfs#18206
Closes openzfs#18424
pull Bot pushed a commit to A-Archives-and-Forks/openzfs that referenced this pull request Sep 26, 2026
@chrislongros @lundman
deb.am: propagate build errors in native-deb targets
99e9227 
Replace semicolons with && so build failures are not masked by the
subsequent lockfile cleanup.  Use trap to ensure the lockfile is
removed on both success and failure.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Christos Longros 
Closes openzfs#18206
Closes openzfs#18424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees

No one assigned

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make native-deb silently succeeds when dpkg-buildpackage fails

3 participants

@chrislongros @tonyhutter @behlendorf