Repository navigation
CI: set /etc/hostid in zloop runner - #18413
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the zloop GitHub Actions workflow to ensure /etc/hostid is present on the CI runner, preventing ztest failures when multihost=on and the system hostid is unset.
Changes:
- Generate
/etc/hostidviazgenhostidwhen missing before creating/importing pools in zloop.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
behlendorf
force-pushed
the
ci-zloop-hostid
branch
from
April 7, 2026 23:38
f4b76a5 to
7a63160
Compare
ztest can enable and disable the multihost property on when testing. This can result in a failure when attempting to import and existing pool when multihost=on but no /etc/hostid file exists. Update the workflow to use zgenhostid to create /etc/hostid when not present. Signed-off-by: Brian Behlendorf
behlendorf
force-pushed
the
ci-zloop-hostid
branch
from
April 8, 2026 04:47
7a63160 to
1de5246
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amotin
approved these changes
Apr 8, 2026
Rudd-O
pushed a commit
to Rudd-O/zfs
that referenced
this pull request
Apr 23, 2026
ztest can enable and disable the multihost property when testing. This can result in a failure when attempting to import an existing pool when multihost=on but no /etc/hostid file exists. Update the workflow to use zgenhostid to create /etc/hostid when not present. Reviewed-by: Alexander MotinSigned-off-by: Brian Behlendorf Closes openzfs#18413
tonyhutter
pushed a commit
that referenced
this pull request
May 12, 2026
ztest can enable and disable the multihost property when testing. This can result in a failure when attempting to import an existing pool when multihost=on but no /etc/hostid file exists. Update the workflow to use zgenhostid to create /etc/hostid when not present. Reviewed-by: Alexander MotinSigned-off-by: Brian Behlendorf Closes #18413
tonyhutter
pushed a commit
that referenced
this pull request
May 12, 2026
ztest can enable and disable the multihost property when testing. This can result in a failure when attempting to import an existing pool when multihost=on but no /etc/hostid file exists. Update the workflow to use zgenhostid to create /etc/hostid when not present. Reviewed-by: Alexander MotinSigned-off-by: Brian Behlendorf Closes #18413
lundman
pushed a commit
to openzfsonosx/openzfs-fork
that referenced
this pull request
Jul 30, 2026
ztest can enable and disable the multihost property when testing. This can result in a failure when attempting to import an existing pool when multihost=on but no /etc/hostid file exists. Update the workflow to use zgenhostid to create /etc/hostid when not present. Reviewed-by: Alexander MotinSigned-off-by: Brian Behlendorf Closes openzfs#18413
pull Bot
pushed a commit
to A-Archives-and-Forks/openzfs
that referenced
this pull request
Sep 26, 2026
ztest can enable and disable the multihost property when testing. This can result in a failure when attempting to import an existing pool when multihost=on but no /etc/hostid file exists. Update the workflow to use zgenhostid to create /etc/hostid when not present. Reviewed-by: Alexander MotinSigned-off-by: Brian Behlendorf Closes openzfs#18413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
https://github.com/openzfs/zfs/actions/runs/24097857703/job/70330214420?pr=18148
Description
ztest can enable and disable the multihost property on when testing. This can result in a failure when attempting to import and existing pool when multihost=on but no /etc/hostid file exists. Update the workflow to use zgenhostid to create /etc/hostid when not present.
How Has This Been Tested?
Will be tested by the CI.
Types of changes
Checklist:
Signed-off-by.