Skip to content

CI: set /etc/hostid in zloop runner - #18413

Merged
behlendorf merged 1 commit into
openzfs:masterfrom
behlendorf:ci-zloop-hostid
Apr 8, 2026
Merged

behlendorf merged 1 commit into
openzfs:masterfrom
behlendorf:ci-zloop-hostid

Conversation

@behlendorf

Copy link
Copy Markdown
Contributor

Motivation and Context

 libzpool: WARNING: pool 'ztest' system hostid not set, aborted import during open
ASSERT at cmd/ztest.c:8412:ztest_run()
VERIFY3S(error, ==, ENOENT) failed (121 == 0x2)
  PID: 114541    COMM: ztest
  TID: 114541    NAME: ztest

https://github.com/openzfs/zfs/actions/runs/24097857703/job/70330214420?pr=18148

Description

ztest can enable and disable the multihost property on when testing. This can result in a failure when attempting to import and existing pool when multihost=on but no /etc/hostid file exists. Update the workflow to use zgenhostid to create /etc/hostid when not present.

How Has This Been Tested?

Will be tested by the CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 7, 2026
Copilot AI review requested due to automatic review settings April 7, 2026 23:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the zloop GitHub Actions workflow to ensure /etc/hostid is present on the CI runner, preventing ztest failures when multihost=on and the system hostid is unset.

Changes:

  • Generate /etc/hostid via zgenhostid when missing before creating/importing pools in zloop.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/zloop.yml Outdated
ztest can enable and disable the multihost property on when testing.
This can result in a failure when attempting to import and existing
pool when multihost=on but no /etc/hostid file exists.  Update the
workflow to use zgenhostid to create /etc/hostid when not present.

Signed-off-by: Brian Behlendorf 
Copilot AI review requested due to automatic review settings April 8, 2026 04:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 8, 2026
@behlendorf
behlendorf merged commit eb5c93f into openzfs:master Apr 8, 2026
30 of 33 checks passed
Rudd-O pushed a commit to Rudd-O/zfs that referenced this pull request Apr 23, 2026
ztest can enable and disable the multihost property when testing.
This can result in a failure when attempting to import an existing
pool when multihost=on but no /etc/hostid file exists.  Update the
workflow to use zgenhostid to create /etc/hostid when not present.

Reviewed-by: Alexander Motin 
Signed-off-by: Brian Behlendorf 
Closes openzfs#18413
tonyhutter pushed a commit that referenced this pull request May 12, 2026
ztest can enable and disable the multihost property when testing.
This can result in a failure when attempting to import an existing
pool when multihost=on but no /etc/hostid file exists.  Update the
workflow to use zgenhostid to create /etc/hostid when not present.

Reviewed-by: Alexander Motin 
Signed-off-by: Brian Behlendorf 
Closes #18413
tonyhutter pushed a commit that referenced this pull request May 12, 2026
ztest can enable and disable the multihost property when testing.
This can result in a failure when attempting to import an existing
pool when multihost=on but no /etc/hostid file exists.  Update the
workflow to use zgenhostid to create /etc/hostid when not present.

Reviewed-by: Alexander Motin 
Signed-off-by: Brian Behlendorf 
Closes #18413
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Jul 30, 2026
ztest can enable and disable the multihost property when testing.
This can result in a failure when attempting to import an existing
pool when multihost=on but no /etc/hostid file exists.  Update the
workflow to use zgenhostid to create /etc/hostid when not present.

Reviewed-by: Alexander Motin 
Signed-off-by: Brian Behlendorf 
Closes openzfs#18413
pull Bot pushed a commit to A-Archives-and-Forks/openzfs that referenced this pull request Sep 26, 2026
ztest can enable and disable the multihost property when testing.
This can result in a failure when attempting to import an existing
pool when multihost=on but no /etc/hostid file exists.  Update the
workflow to use zgenhostid to create /etc/hostid when not present.

Reviewed-by: Alexander Motin 
Signed-off-by: Brian Behlendorf 
Closes openzfs#18413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants