Skip to content

config: fix STATX_MNT_ID detection - #18312

Merged
behlendorf merged 1 commit into
openzfs:masterfrom
robn:config-statx-gnu-source
Mar 12, 2026
Merged

config: fix STATX_MNT_ID detection#18312
behlendorf merged 1 commit into
openzfs:masterfrom
robn:config-statx-gnu-source

Conversation

@robn

@robn robn commented Mar 12, 2026

Copy link
Copy Markdown
Member

[Sponsors: TrueNAS]

Motivation and Context

statx(2) requires _GNU_SOURCE to be defined in order for sys/stat.h to produce a definition for struct statx and the STATX_* defines. We get that at compile time because we pass -D_GNU_SOURCE through to everything, but in the configure check we aren't setting _GNU_SOURCE, so we don't find STATX_MNT_ID, and so don't set HAVE_STATX_MNT_ID.

(This was fine before ccf5a8a, because linux/stat.h does not require _GNU_SOURCE).

Description

Simple fix: in the check, define _GNU_SOURCE before including sys/stat.h.

How Has This Been Tested?

Compile checked only. I'll be relying on CI to see if any important behaviour changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@robn
config: fix STATX_MNT_ID detection
9ecdac2 
statx(2) requires _GNU_SOURCE to be defined in order for sys/stat.h to
produce a definition for struct statx and the STATX_* defines. We get
that at compile time because we pass -D_GNU_SOURCE through to
everything, but in the configure check we aren't setting _GNU_SOURCE, so
we don't find STATX_MNT_ID, and so don't set HAVE_STATX_MNT_ID.

(This was fine before ccf5a8a, because linux/stat.h does not require
_GNU_SOURCE).

Simple fix: in the check, define _GNU_SOURCE before including
sys/stat.h.

Sponsored-by: TrueNAS
Signed-off-by: Rob Norris
@robn
robn requested a review from ixhamza March 12, 2026 05:45
@robn robn changed the title config: fix STATX_MNT_ID detection config: fix STATX_MNT_ID detection Mar 12, 2026
ixhamza
ixhamza approved these changes Mar 12, 2026
View reviewed changes

@ixhamza ixhamza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 12, 2026
@behlendorf
behlendorf merged commit 2b930f6 into openzfs:master Mar 12, 2026
31 of 41 checks passed
ixhamza pushed a commit to truenas/zfs that referenced this pull request Mar 12, 2026
@robn @ixhamza
config: fix STATX_MNT_ID detection
1d6d690 
statx(2) requires _GNU_SOURCE to be defined in order for sys/stat.h to
produce a definition for struct statx and the STATX_* defines. We get
that at compile time because we pass -D_GNU_SOURCE through to
everything, but in the configure check we aren't setting _GNU_SOURCE, so
we don't find STATX_MNT_ID, and so don't set HAVE_STATX_MNT_ID.

(This was fine before ccf5a8a, because linux/stat.h does not require
_GNU_SOURCE).

Simple fix: in the check, define _GNU_SOURCE before including
sys/stat.h.

Sponsored-by: TrueNAS
Reviewed-by: Ameer Hamza 
Reviewed-by: Brian Behlendorf 
Signed-off-by: Rob Norris 
Closes openzfs#18312
@ixhamza ixhamza mentioned this pull request Mar 12, 2026
Merged
14 tasks
@bugclerk bugclerk mentioned this pull request Mar 12, 2026
Closed
14 tasks
bugclerk pushed a commit to truenas/zfs that referenced this pull request Mar 12, 2026
@robn @bugclerk
config: fix STATX_MNT_ID detection
7182ebc 
statx(2) requires _GNU_SOURCE to be defined in order for sys/stat.h to
produce a definition for struct statx and the STATX_* defines. We get
that at compile time because we pass -D_GNU_SOURCE through to
everything, but in the configure check we aren't setting _GNU_SOURCE, so
we don't find STATX_MNT_ID, and so don't set HAVE_STATX_MNT_ID.

(This was fine before ccf5a8a, because linux/stat.h does not require
_GNU_SOURCE).

Simple fix: in the check, define _GNU_SOURCE before including
sys/stat.h.

Sponsored-by: TrueNAS
Reviewed-by: Ameer Hamza 
Reviewed-by: Brian Behlendorf 
Signed-off-by: Rob Norris 
Closes openzfs#18312
(cherry picked from commit 1d6d690)
@bugclerk bugclerk mentioned this pull request Mar 12, 2026
Merged
14 tasks
bugclerk pushed a commit to truenas/zfs that referenced this pull request Mar 12, 2026
@robn @bugclerk
config: fix STATX_MNT_ID detection
54999ad 
statx(2) requires _GNU_SOURCE to be defined in order for sys/stat.h to
produce a definition for struct statx and the STATX_* defines. We get
that at compile time because we pass -D_GNU_SOURCE through to
everything, but in the configure check we aren't setting _GNU_SOURCE, so
we don't find STATX_MNT_ID, and so don't set HAVE_STATX_MNT_ID.

(This was fine before ccf5a8a, because linux/stat.h does not require
_GNU_SOURCE).

Simple fix: in the check, define _GNU_SOURCE before including
sys/stat.h.

Sponsored-by: TrueNAS
Reviewed-by: Ameer Hamza 
Reviewed-by: Brian Behlendorf 
Signed-off-by: Rob Norris 
Closes openzfs#18312
(cherry picked from commit 1d6d690)
@bugclerk bugclerk mentioned this pull request Mar 12, 2026
Merged
14 tasks
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
config: fix STATX_MNT_ID detection
ba8036f 
statx(2) requires _GNU_SOURCE to be defined in order for sys/stat.h to
produce a definition for struct statx and the STATX_* defines. We get
that at compile time because we pass -D_GNU_SOURCE through to
everything, but in the configure check we aren't setting _GNU_SOURCE, so
we don't find STATX_MNT_ID, and so don't set HAVE_STATX_MNT_ID.

(This was fine before ccf5a8a, because linux/stat.h does not require
_GNU_SOURCE).

Simple fix: in the check, define _GNU_SOURCE before including
sys/stat.h.

Sponsored-by: TrueNAS
Reviewed-by: Ameer Hamza 
Reviewed-by: Brian Behlendorf 
Signed-off-by: Rob Norris 
Closes #18312
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
config: fix STATX_MNT_ID detection
97949da 
statx(2) requires _GNU_SOURCE to be defined in order for sys/stat.h to
produce a definition for struct statx and the STATX_* defines. We get
that at compile time because we pass -D_GNU_SOURCE through to
everything, but in the configure check we aren't setting _GNU_SOURCE, so
we don't find STATX_MNT_ID, and so don't set HAVE_STATX_MNT_ID.

(This was fine before ccf5a8a, because linux/stat.h does not require
_GNU_SOURCE).

Simple fix: in the check, define _GNU_SOURCE before including
sys/stat.h.

Sponsored-by: TrueNAS
Reviewed-by: Ameer Hamza 
Reviewed-by: Brian Behlendorf 
Signed-off-by: Rob Norris 
Closes #18312
@robn
robn deleted the config-statx-gnu-source branch June 14, 2026 05:36
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Jul 30, 2026
@robn @lundman
config: fix STATX_MNT_ID detection
5f88870 
statx(2) requires _GNU_SOURCE to be defined in order for sys/stat.h to
produce a definition for struct statx and the STATX_* defines. We get
that at compile time because we pass -D_GNU_SOURCE through to
everything, but in the configure check we aren't setting _GNU_SOURCE, so
we don't find STATX_MNT_ID, and so don't set HAVE_STATX_MNT_ID.

(This was fine before ccf5a8a, because linux/stat.h does not require
_GNU_SOURCE).

Simple fix: in the check, define _GNU_SOURCE before including
sys/stat.h.

Sponsored-by: TrueNAS
Reviewed-by: Ameer Hamza 
Reviewed-by: Brian Behlendorf 
Signed-off-by: Rob Norris 
Closes openzfs#18312
pull Bot pushed a commit to A-Archives-and-Forks/openzfs that referenced this pull request Sep 26, 2026
@robn @lundman
config: fix STATX_MNT_ID detection
9d0b5b8 
statx(2) requires _GNU_SOURCE to be defined in order for sys/stat.h to
produce a definition for struct statx and the STATX_* defines. We get
that at compile time because we pass -D_GNU_SOURCE through to
everything, but in the configure check we aren't setting _GNU_SOURCE, so
we don't find STATX_MNT_ID, and so don't set HAVE_STATX_MNT_ID.

(This was fine before ccf5a8a, because linux/stat.h does not require
_GNU_SOURCE).

Simple fix: in the check, define _GNU_SOURCE before including
sys/stat.h.

Sponsored-by: TrueNAS
Reviewed-by: Ameer Hamza 
Reviewed-by: Brian Behlendorf 
Signed-off-by: Rob Norris 
Closes openzfs#18312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behlendorf behlendorf behlendorf approved these changes
+1 more reviewer
@ixhamza ixhamza ixhamza approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robn @behlendorf @ixhamza