Repository navigation
ZTS: Adjust mmp_on_uberblocks threshold - #18280
Merged
Merged
Conversation
Decrease the number of required uberblock blocks write slightly due to observed variation when running in the CI. This should help avoid future false positives. Signed-off-by: Brian Behlendorf
There was a problem hiding this comment.
Pull request overview
Adjusts the ZFS Test Suite’s MMP uberblock sequencing threshold to reduce CI flakiness/false positives when validating mmp_seq progression under MULTIHOST_INTERVAL tuning.
Changes:
- Lowers
MIN_SEQ_VALUESfrom 10 to 8 in themmp_on_uberblocksfunctional test to better match observed CI variability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tonyhutter
approved these changes
Mar 3, 2026
tonyhutter
pushed a commit
that referenced
this pull request
May 12, 2026
Decrease the number of required uberblock blocks write slightly due to observed variation when running in the CI. This should help avoid future false positives. Reviewed-by: Tony HutterSigned-off-by: Brian Behlendorf Closes #18280
lundman
pushed a commit
to openzfsonosx/openzfs-fork
that referenced
this pull request
Jul 30, 2026
Decrease the number of required uberblock blocks write slightly due to observed variation when running in the CI. This should help avoid future false positives. Reviewed-by: Tony HutterSigned-off-by: Brian Behlendorf Closes openzfs#18280
pull Bot
pushed a commit
to A-Archives-and-Forks/openzfs
that referenced
this pull request
Sep 26, 2026
Decrease the number of required uberblock blocks write slightly due to observed variation when running in the CI. This should help avoid future false positives. Reviewed-by: Tony HutterSigned-off-by: Brian Behlendorf Closes openzfs#18280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Further reduce false positives in the CI. For example,
https://github.com/openzfs/zfs/actions/runs/22623131399/job/65552855503?pr=18277
Description
Decrease the number of required uberblock blocks write slightly due to observed variation when running in the CI.
How Has This Been Tested?
Updated value based on the lower value I've observed when looking at the CI results. Will be tested by the CI.
Types of changes
Checklist:
Signed-off-by.