Skip to content

ZTS: Adjust mmp_on_uberblocks threshold - #18280

Merged
behlendorf merged 1 commit into
openzfs:masterfrom
behlendorf:zts-mmp_on_uberblocks
Mar 3, 2026
Merged

behlendorf merged 1 commit into
openzfs:masterfrom
behlendorf:zts-mmp_on_uberblocks

Conversation

@behlendorf

Copy link
Copy Markdown
Contributor

Motivation and Context

Further reduce false positives in the CI. For example,

https://github.com/openzfs/zfs/actions/runs/22623131399/job/65552855503?pr=18277

Description

Decrease the number of required uberblock blocks write slightly due to observed variation when running in the CI.

How Has This Been Tested?

Updated value based on the lower value I've observed when looking at the CI results. Will be tested by the CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Decrease the number of required uberblock blocks write slightly due
to observed variation when running in the CI.  This should help
avoid future false positives.

Signed-off-by: Brian Behlendorf 
Copilot AI review requested due to automatic review settings March 3, 2026 17:21
@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Mar 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the ZFS Test Suite’s MMP uberblock sequencing threshold to reduce CI flakiness/false positives when validating mmp_seq progression under MULTIHOST_INTERVAL tuning.

Changes:

  • Lowers MIN_SEQ_VALUES from 10 to 8 in the mmp_on_uberblocks functional test to better match observed CI variability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/zfs-tests/tests/functional/mmp/mmp_on_uberblocks.ksh
Comment thread tests/zfs-tests/tests/functional/mmp/mmp_on_uberblocks.ksh
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 3, 2026
@behlendorf
behlendorf merged commit f6205fd into openzfs:master Mar 3, 2026
24 of 30 checks passed
@behlendorf
behlendorf deleted the zts-mmp_on_uberblocks branch April 22, 2026 22:35
tonyhutter pushed a commit that referenced this pull request May 12, 2026
Decrease the number of required uberblock blocks write slightly due
to observed variation when running in the CI.  This should help
avoid future false positives.

Reviewed-by: Tony Hutter 
Signed-off-by: Brian Behlendorf 
Closes #18280
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Jul 30, 2026
Decrease the number of required uberblock blocks write slightly due
to observed variation when running in the CI.  This should help
avoid future false positives.

Reviewed-by: Tony Hutter 
Signed-off-by: Brian Behlendorf 
Closes openzfs#18280
pull Bot pushed a commit to A-Archives-and-Forks/openzfs that referenced this pull request Sep 26, 2026
Decrease the number of required uberblock blocks write slightly due
to observed variation when running in the CI.  This should help
avoid future false positives.

Reviewed-by: Tony Hutter 
Signed-off-by: Brian Behlendorf 
Closes openzfs#18280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants