Repository navigation
Linux 6.19: handle --werror with CONFIG_OBJTOOL_WERROR=y - #18152
Merged
behlendorf merged 1 commit intoFeb 2, 2026
Merged
behlendorf merged 1 commit into
behlendorf merged 1 commit into
Conversation
john-cabaj
force-pushed
the
john-cabaj/handle_objtool_werror_and_Werror
branch
from
January 22, 2026 21:27
93b014f to
9e84a93
Compare
AttilaFueloep
approved these changes
Jan 23, 2026
john-cabaj
force-pushed
the
john-cabaj/handle_objtool_werror_and_Werror
branch
from
January 23, 2026 14:46
9e84a93 to
973e23b
Compare
Contributor
Author
|
Modifying the commit message and PR title to indicate this is needed for Linux 6.19 compat. No functional changes. |
john-cabaj
force-pushed
the
john-cabaj/handle_objtool_werror_and_Werror
branch
from
January 27, 2026 18:44
973e23b to
60d7bb3
Compare
tonyhutter
approved these changes
Jan 27, 2026
john-cabaj
force-pushed
the
john-cabaj/handle_objtool_werror_and_Werror
branch
from
January 30, 2026 16:08
60d7bb3 to
d9cfc41
Compare
Linux upstream commit 56754f0f46f6: "objtool: Rename --Werror to --werror" did just that, so we should check for either "--Werror" or "--werror", else the build will fail Signed-off-by: John Cabaj
behlendorf
force-pushed
the
john-cabaj/handle_objtool_werror_and_Werror
branch
from
February 1, 2026 21:29
d9cfc41 to
eee61f2
Compare
behlendorf
approved these changes
Feb 2, 2026
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 11, 2026
Linux upstream commit 56754f0f46f6: "objtool: Rename --Werror to --werror" did just that, so we should check for either "--Werror" or "--werror", else the build will fail Reviewed-by: Brian BehlendorfReviewed-by: Attila Fülöp Reviewed-by: Tony Hutter Signed-off-by: John Cabaj Closes openzfs#18152
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 11, 2026
Linux upstream commit 56754f0f46f6: "objtool: Rename --Werror to --werror" did just that, so we should check for either "--Werror" or "--werror", else the build will fail Reviewed-by: Brian BehlendorfReviewed-by: Attila Fülöp Reviewed-by: Tony Hutter Signed-off-by: John Cabaj Closes openzfs#18152
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 12, 2026
Linux upstream commit 56754f0f46f6: "objtool: Rename --Werror to --werror" did just that, so we should check for either "--Werror" or "--werror", else the build will fail Reviewed-by: Brian BehlendorfReviewed-by: Attila Fülöp Reviewed-by: Tony Hutter Signed-off-by: John Cabaj Closes openzfs#18152
pull Bot
pushed a commit
to A-Archives-and-Forks/openzfs
that referenced
this pull request
Sep 26, 2026
Linux upstream commit 56754f0f46f6: "objtool: Rename --Werror to --werror" did just that, so we should check for either "--Werror" or "--werror", else the build will fail Reviewed-by: Brian BehlendorfReviewed-by: Attila Fülöp Reviewed-by: Tony Hutter Signed-off-by: John Cabaj Closes openzfs#18152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When building against a 6.19 kernel using the Ubuntu 26.04 development build with
CONFIG_OBJTOOL_WERROR=y, the zfs-linux DKMS package fails to build due to the following errors:This is because the upstream Linux kernel introduced a change in 6.19-rc1 (56754f0f46f6: "objtool: Rename --Werror to --werror"), which doesn't match the changes in scripts/objtool-wrapper.in to ignore the compiler flag.
Description
Simple change to modify scripts/objtool-wrapper.in to look for both "--Werror" and "--werror", rather than just the former.
How Has This Been Tested?
This was tested in a QEMU environment using virtme-ng, after bisecting the Linux kernel changes down to the aforementioned commit. Using the changes in this PR, zfs-linux successfully built.
Tests were repeated on a LXD VM, whereupon some simple regression tests were also executed, notably the tests from here - https://git.launchpad.net/~canonical-kernel-team/+git/autotest-client-tests (see "ubuntu_zfs_*" tests).
Types of changes
Checklist:
Signed-off-by.