Skip to content

RAIDZ: Remove some excessive logging - #18059

Merged
behlendorf merged 1 commit into
openzfs:masterfrom
amotin:raidz_dbgmsg
Dec 17, 2025
Merged

behlendorf merged 1 commit into
openzfs:masterfrom
amotin:raidz_dbgmsg

Conversation

@amotin

@amotin amotin commented Dec 16, 2025

Copy link
Copy Markdown
Member

There were some per I/O logging into dbgmsg in RAIDZ code, that increased CPU load and wiped useful content out of dbgmsg, for example during routine disk replacement process. I don't think we need it to be that verbose.

How Has This Been Tested?

# zpool offline optane nvd5p1
# zpool replace optane nvd5p1 nvd4p1

, and observe dbgmsg no longer trashed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

There were some per I/O logging into dbgmsg in RAIDZ code, that
increased CPU load and wiped useful content out of dbgmsg, for
example during routine disk replacement process.  I don't think
we need it to be that verbose.

Signed-off-by: Alexander Motin 
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Dec 16, 2025

@behlendorf behlendorf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, we can shed these.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 17, 2025
@behlendorf
behlendorf merged commit 0550abd into openzfs:master Dec 17, 2025
26 checks passed
amotin added a commit to amotin/zfs that referenced this pull request Jan 29, 2026
There were some per I/O logging into dbgmsg in RAIDZ code, that
increased CPU load and wiped useful content out of dbgmsg, for
example during routine disk replacement process.  I don't think
we need it to be that verbose.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Alexander Motin 
Closes openzfs#18059
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 31, 2026
There were some per I/O logging into dbgmsg in RAIDZ code, that
increased CPU load and wiped useful content out of dbgmsg, for
example during routine disk replacement process.  I don't think
we need it to be that verbose.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Alexander Motin 
Closes openzfs#18059
amotin added a commit to amotin/zfs that referenced this pull request Feb 3, 2026
There were some per I/O logging into dbgmsg in RAIDZ code, that
increased CPU load and wiped useful content out of dbgmsg, for
example during routine disk replacement process.  I don't think
we need it to be that verbose.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Alexander Motin 
Closes openzfs#18059
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Feb 5, 2026
There were some per I/O logging into dbgmsg in RAIDZ code, that
increased CPU load and wiped useful content out of dbgmsg, for
example during routine disk replacement process.  I don't think
we need it to be that verbose.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Alexander Motin 
Closes openzfs#18059
tonyhutter pushed a commit that referenced this pull request Feb 5, 2026
There were some per I/O logging into dbgmsg in RAIDZ code, that
increased CPU load and wiped useful content out of dbgmsg, for
example during routine disk replacement process.  I don't think
we need it to be that verbose.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Alexander Motin 
Closes #18059
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
There were some per I/O logging into dbgmsg in RAIDZ code, that
increased CPU load and wiped useful content out of dbgmsg, for
example during routine disk replacement process.  I don't think
we need it to be that verbose.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Alexander Motin 
Closes openzfs#18059
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
There were some per I/O logging into dbgmsg in RAIDZ code, that
increased CPU load and wiped useful content out of dbgmsg, for
example during routine disk replacement process.  I don't think
we need it to be that verbose.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Alexander Motin 
Closes openzfs#18059
tonyhutter pushed a commit that referenced this pull request May 12, 2026
There were some per I/O logging into dbgmsg in RAIDZ code, that
increased CPU load and wiped useful content out of dbgmsg, for
example during routine disk replacement process.  I don't think
we need it to be that verbose.

Reviewed-by: Brian Behlendorf 
Signed-off-by: Alexander Motin 
Closes #18059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants