Allow zdb -r to understand object ids as well

[allanjude]

Sponsored-by: Klara, Inc.
Sponsored-By: Wasabi Technology, Inc.

Motivation and Context

Previously I created: zdb -r pool/dataset path/to/file /tmp/recover.dat

But it turns out, if there is a problem with a directory, you might want to recover a file by its inode number instead

Description

If the argument is a number, thread it as the object-id instead of a filename

How Has This Been Tested?

Manually

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[allanjude]

@kithrup made some changes to this, so it now uses -O instead, and that should solve things. Can folks look again now?

[behlendorf]

I'm happy to take another look, but could you first rebase this on master and resolve the build issue.

  cmd/zdb/zdb.c: In function ‘usage’:
  cmd/zdb/zdb.c:724:13: error: format ‘%s’ expects a matching ‘char *’ argument [-Werror=format=]
    724 |             "Usage:\t%s [-AbcdDFGhikLMPsvXy] [-e [-V] [-p  ...]] "
        |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cmd/zdb/zdb.c:745:17: note: format string is defined here
    745 |             "\t%s -S [-AP] [-e [-V] [-p  ...]] [-U ] "
        |                ~^
        |                 |
        |                 char *

[kithrup]

I'm happy to take another look, but could you first rebase this on master and resolve the build issue.

Done, thanks!

[akashb-22]

LGTM