Skip to content

Skip remote Git discovery for Guardian diff paths - #49082

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/3661759119935c68539e9eab8df2e862987d0d92
Sep 28, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/3661759119935c68539e9eab8df2e862987d0d92

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Skip remote Git discovery for Guardian diff paths

Why

An offline secondary executor can stall Guardian approval revalidation while diff display setup searches for Git roots, even when the review concerns another executor.

What changed

Use each environment's working directory as the diff display root for Guardian sessions, regardless of CwdRelativeTurnDiffs, so this setup does not wait for remote Git discovery.

Testing

Add a regression test that withdraws authorization during a pending approval and disconnects an unrelated secondary executor. Verify that Guardian retries with the updated authorization and denies the request.

## Why

An offline secondary executor can stall Guardian approval revalidation while diff display setup searches for Git roots, even when the review concerns another executor.

## What changed

Use each environment's working directory as the diff display root for Guardian sessions, regardless of `CwdRelativeTurnDiffs`, so this setup does not wait for remote Git discovery.

## Testing

Add a regression test that withdraws authorization during a pending approval and disconnects an unrelated secondary executor. Verify that Guardian retries with the updated authorization and denies the request.

GitOrigin-RevId: 3661759119935c68539e9eab8df2e862987d0d92
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/3661759119935c68539e9eab8df2e862987d0d92 branch from 165b81a to 46d2585 Compare September 28, 2026 21:18
@copyberry
copyberry Bot merged commit 46d2585 into main Sep 28, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/3661759119935c68539e9eab8df2e862987d0d92 branch September 28, 2026 21:18
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 28, 2026
@goneflyin
goneflyin deployed to issue-triage September 28, 2026 21:25 — with GitHub Actions Active
@goneflyin
goneflyin deployed to issue-triage September 28, 2026 21:25 — with GitHub Actions Active
@goneflyin
goneflyin deployed to issue-triage September 28, 2026 21:25 — with GitHub Actions Active
@goneflyin
goneflyin deployed to issue-triage September 28, 2026 21:26 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants