Repository navigation
Fix Windows sandbox ACL repair for long runtime paths - #49058
Merged
copyberry[bot] merged 1 commit intoSep 28, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Runtime ACL repair needs to handle nested files and directories beyond the legacy Windows path limit. ## What changed Use Rust's `OpenOptions` for ACL reads and handle-based `SetSecurityInfo` for updates to support extended-length paths. Request ACL-write access only when grants need updating, and share allocation cleanup across success and error paths. ## Testing Add a regression test covering long directory and file paths alongside a short-path control. Verify repeated repairs grant read/execute access without granting write, delete, or ACL-management rights, and that already-correct grants remain no-ops. GitOrigin-RevId: 325c17085fa4379eebe982d49175dd2151b0681e
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/325c17085fa4379eebe982d49175dd2151b0681e
branch
from
September 28, 2026 19:01
3a64ae5 to
df3e439
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/325c17085fa4379eebe982d49175dd2151b0681e
branch
September 28, 2026 19:01
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows sandbox ACL repair for long runtime paths
Why
Runtime ACL repair needs to handle nested files and directories beyond the legacy Windows path limit.
What changed
Use Rust's
OpenOptionsfor ACL reads and handle-basedSetSecurityInfofor updates to support extended-length paths. Request ACL-write access only when grants need updating, and share allocation cleanup across success and error paths.Testing
Add a regression test covering long directory and file paths alongside a short-path control. Verify repeated repairs grant read/execute access without granting write, delete, or ACL-management rights, and that already-correct grants remain no-ops.