Repository navigation
Isolate executable fixture copies in CLI tests on Linux - #48213
Merged
copyberry[bot] merged 1 commit intoSep 25, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Sibling tests can spawn children while an executable fixture is open for writing, allowing inherited writable descriptors to cause `ETXTBSY` when launching the fixture. ## What changed Add a shared `copy_executable` helper for the daemon, doctor path safety, and exec-server tests. On Linux, run `/bin/cp` in a separate process and wait for it to exit before launching the fixture, then restore the source permissions to account for restrictive umasks. Keep `std::fs::copy` on other platforms. GitOrigin-RevId: 88f36826bbc6ab4e16e28ff02d5e7d6bd8dbf793
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/88f36826bbc6ab4e16e28ff02d5e7d6bd8dbf793
branch
from
September 25, 2026 20:54
054923f to
58670ee
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/88f36826bbc6ab4e16e28ff02d5e7d6bd8dbf793
branch
September 25, 2026 20:54
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolate executable fixture copies in CLI tests on Linux
Why
Sibling tests can spawn children while an executable fixture is open for
writing, allowing inherited writable descriptors to cause
ETXTBSYwhenlaunching the fixture.
What changed
Add a shared
copy_executablehelper for the daemon, doctor path safety, andexec-server tests. On Linux, run
/bin/cpin a separate process and wait forit to exit before launching the fixture, then restore the source permissions
to account for restrictive umasks. Keep
std::fs::copyon other platforms.