Skip to content

Make project trust lookup paths explicit and defer root resolution - #47924

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/ba5dc0df1ef9d5109933df00c055eef04434601f
Sep 24, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/ba5dc0df1ef9d5109933df00c055eef04434601f

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Make project trust lookup paths explicit and defer root resolution

What changed

  • Export ProjectTrustPath and make ProjectTrustLookup::from_paths accept an explicit working directory and optional repository root instead of an arbitrary sequence of path pairs.
  • Defer repository-root canonicalization until neither working-directory key matches, avoiding unnecessary filesystem access while preserving lookup precedence.

Testing

Extend the active-project regression test to cover repository-root fallback and ensure a working-directory entry without a trust level takes precedence over a trusted root. Adapt the existing POSIX and Windows lookup tests to the new API.

…47924)

## What changed

- Export `ProjectTrustPath` and make `ProjectTrustLookup::from_paths` accept an explicit working directory and optional repository root instead of an arbitrary sequence of path pairs.
- Defer repository-root canonicalization until neither working-directory key matches, avoiding unnecessary filesystem access while preserving lookup precedence.

## Testing

Extend the active-project regression test to cover repository-root fallback and ensure a working-directory entry without a trust level takes precedence over a trusted root. Adapt the existing POSIX and Windows lookup tests to the new API.

GitOrigin-RevId: ba5dc0df1ef9d5109933df00c055eef04434601f
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/ba5dc0df1ef9d5109933df00c055eef04434601f branch from d5496d7 to 1866e51 Compare September 24, 2026 19:45
@copyberry
copyberry Bot merged commit 1866e51 into main Sep 24, 2026
1 check failed
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/ba5dc0df1ef9d5109933df00c055eef04434601f branch September 24, 2026 19:45
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 24, 2026

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants