Skip to content

Warn users when SQLite diagnostic log writes fail - #47887

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/12a74126d13c3568430e539a180cca47fa931fa9
Sep 24, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/12a74126d13c3568430e539a180cca47fa931fa9

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Warn users when SQLite diagnostic log writes fail

Why

Failed SQLite writes leave diagnostic logs incomplete. Notify users before they close Codex so they can submit logs or run codex doctor.

What changed

  • Add a best-effort warning on the first log write failure in standalone and in-process app servers, while continuing to retain failure diagnostics in memory.
  • Handle failures that occurred before the in-process warning reporter was attached.
  • Tailor the warning's guidance to whether submitting logs is enabled.

Testing

Add coverage for warning deduplication, both guidance variants, retained diagnostics after the notification sender is dropped, and SQLite flush failures before and after reporter attachment. Extend log upload integration coverage and add a TUI warnings snapshot.

## Why

Failed SQLite writes leave diagnostic logs incomplete. Notify users before they close Codex so they can submit logs or run `codex doctor`.

## What changed

- Add a best-effort warning on the first log write failure in standalone and in-process app servers, while continuing to retain failure diagnostics in memory.
- Handle failures that occurred before the in-process warning reporter was attached.
- Tailor the warning's guidance to whether submitting logs is enabled.

## Testing

Add coverage for warning deduplication, both guidance variants, retained diagnostics after the notification sender is dropped, and SQLite flush failures before and after reporter attachment. Extend log upload integration coverage and add a TUI warnings snapshot.

GitOrigin-RevId: 12a74126d13c3568430e539a180cca47fa931fa9
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/12a74126d13c3568430e539a180cca47fa931fa9 branch from a4a4b1a to 3d64285 Compare September 24, 2026 17:05
@copyberry
copyberry Bot merged commit 3d64285 into main Sep 24, 2026
1 check failed
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/12a74126d13c3568430e539a180cca47fa931fa9 branch September 24, 2026 17:05
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 24, 2026
@AuricTW
AuricTW deployed to issue-triage September 24, 2026 17:15 — with GitHub Actions Active
@AuricTW
AuricTW deployed to issue-triage September 24, 2026 17:15 — with GitHub Actions Active
@AuricTW
AuricTW deployed to issue-triage September 24, 2026 17:15 — with GitHub Actions Active
@AuricTW
AuricTW deployed to issue-triage September 24, 2026 17:16 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 3d642851 Deployed Sep 24, 2026 by AuricTW via Identify potential duplicates (open issues fallback) #48048
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants