Skip to content

Fix PID reservation test race and update guardian heartbeat snapshot - #47871

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/d9cadae0e5d36cb2e1ab0517e2d7121cf2d0715d
Sep 24, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/d9cadae0e5d36cb2e1ab0517e2d7121cf2d0715d

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Fix PID reservation test race and update guardian heartbeat snapshot

Why

The PID reservation test could race with the backend's read on Windows by deleting the PID file from its cleanup task. The guardian heartbeat snapshot and environment normalization also needed to match the current permission-context wording.

What changed

  • Release the reservation lock and let stop() remove the stale PID file, then assert that the file is gone.
  • Update the guardian heartbeat snapshot and normalization pattern to use The active permission profile for environment.

…47871)

## Why

The PID reservation test could race with the backend's read on Windows by deleting the PID file from its cleanup task. The guardian heartbeat snapshot and environment normalization also needed to match the current permission-context wording.

## What changed

- Release the reservation lock and let `stop()` remove the stale PID file, then assert that the file is gone.
- Update the guardian heartbeat snapshot and normalization pattern to use `The active permission profile for environment`.

GitOrigin-RevId: d9cadae0e5d36cb2e1ab0517e2d7121cf2d0715d
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/d9cadae0e5d36cb2e1ab0517e2d7121cf2d0715d branch from 51efc33 to 4226624 Compare September 24, 2026 16:07
@copyberry
copyberry Bot merged commit 4226624 into main Sep 24, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/d9cadae0e5d36cb2e1ab0517e2d7121cf2d0715d branch September 24, 2026 16:07
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 24, 2026
@oyosefi
oyosefi deployed to issue-triage September 24, 2026 16:13 — with GitHub Actions Active
@oyosefi
oyosefi deployed to issue-triage September 24, 2026 16:13 — with GitHub Actions Active
@oyosefi
oyosefi deployed to issue-triage September 24, 2026 16:13 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 42266240 Deployed Sep 24, 2026 by oyosefi via Generate label suggestions #48026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants