Repository navigation
Validate loaded plugins outside the cache lock - #47858
Merged
copyberry[bot] merged 1 commit intoSep 24, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Checking installed plugin roots performs filesystem work while holding the loaded plugins cache mutex, blocking lookups for other cache keys. ## What changed Store cache entries in `Arc`s and release the mutex before validating installation paths. After reacquiring the lock, check the cache generation and entry identity to reject entries invalidated or replaced during validation. Preserve stale-entry eviction and most-recently-used ordering. GitOrigin-RevId: cb5a5f7ec52cba852e6bb9da03a8e214cc19727d
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/cb5a5f7ec52cba852e6bb9da03a8e214cc19727d
branch
from
September 24, 2026 14:58
10313c5 to
58838df
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/cb5a5f7ec52cba852e6bb9da03a8e214cc19727d
branch
September 24, 2026 14:58
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate loaded plugins outside the cache lock
Why
Checking installed plugin roots performs filesystem work while holding the loaded plugins cache mutex, blocking lookups for other cache keys.
What changed
Store cache entries in
Arcs and release the mutex before validating installation paths. After reacquiring the lock, check the cache generation and entry identity to reject entries invalidated or replaced during validation. Preserve stale-entry eviction and most-recently-used ordering.