Repository navigation
Initialize media estimates outside the global cache lock - #47856
Merged
copyberry[bot] merged 1 commit intoSep 24, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Image and audio estimate cache misses computed values while holding the cache mutex, blocking access to unrelated keys during initialization. ## What changed Add `BlockingLruCache::get_or_init` using `Arc>` and migrate the image and audio estimate caches to it. Initialization and same-key waits run in a Tokio blocking region after releasing the cache mutex. Callers share initialization while an entry remains cached; eviction can allow another initialization, so factories must be deterministic. ## Testing Add a concurrency test covering access to other keys during initialization, eviction of an in-flight entry, and successful completion of both the evicted initializer and its replacement. GitOrigin-RevId: 079226a58828b854eddc2b501079527bcbe5e603
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/079226a58828b854eddc2b501079527bcbe5e603
branch
from
September 24, 2026 14:58
593a1bc to
df06bb0
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/079226a58828b854eddc2b501079527bcbe5e603
branch
September 24, 2026 14:58
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize media estimates outside the global cache lock
Why
Image and audio estimate cache misses computed values while holding the cache mutex, blocking access to unrelated keys during initialization.
What changed
Add
BlockingLruCache::get_or_initusingArc> and migrate the image and audio estimate caches to it. Initialization and same-key waits run in a Tokio blocking region after releasing the cache mutex. Callers share initialization while an entry remains cached; eviction can allow another initialization, so factories must be deterministic.Testing
Add a concurrency test covering access to other keys during initialization, eviction of an in-flight entry, and successful completion of both the evicted initializer and its replacement.