Skip to content

Centralize typed app-server response decoding - #47755

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/573c6c45859a96cab69888c3a90c29caa93368b1
Sep 24, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/573c6c45859a96cab69888c3a90c29caa93368b1

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Centralize typed app-server response decoding

What changed

Share response decoding and typed error mapping across in-process and remote clients and request handles. Route enum wrappers through request, and drop the completed transport future before invoking caller-provided deserialization.

Testing

Add coverage for dropping typed requests while waiting to send or receive a reply. Exercise the remote typed round trip through AppServerClient::Remote.

## What changed

Share response decoding and typed error mapping across in-process and remote clients and request handles. Route enum wrappers through `request`, and drop the completed transport future before invoking caller-provided deserialization.

## Testing

Add coverage for dropping typed requests while waiting to send or receive a reply. Exercise the remote typed round trip through `AppServerClient::Remote`.

GitOrigin-RevId: 573c6c45859a96cab69888c3a90c29caa93368b1
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/573c6c45859a96cab69888c3a90c29caa93368b1 branch from 8e2e4e7 to a83ba61 Compare September 24, 2026 05:23
@copyberry
copyberry Bot merged commit a83ba61 into main Sep 24, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/573c6c45859a96cab69888c3a90c29caa93368b1 branch September 24, 2026 05:23
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 24, 2026

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants