Repository navigation
Fix no-reparse directory opens on Windows 10 - #47672
Merged
copyberry[bot] merged 1 commit intoSep 23, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Windows 10 rejects the Object Manager drive-letter link when opening a directory with `OBJ_DONT_REPARSE`, preventing ordinary local-drive paths from opening successfully. ## What changed Resolve drive-letter aliases with `QueryDosDeviceW` before calling `NtCreateFile`. Accept only direct disk-volume mappings, rejecting other devices and volume subpaths. Leave filesystem components unresolved so `OBJ_DONT_REPARSE` continues to reject filesystem reparse points. ## Testing Add tests for drive-root opens and NT path construction using ordinary and verbatim drive paths, plus validation of accepted disk-volume mappings and rejected device or subpath mappings. GitOrigin-RevId: 2fe81913a7ac8d0122ec423db5750e80241def56
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/2fe81913a7ac8d0122ec423db5750e80241def56
branch
from
September 23, 2026 21:35
a0bb157 to
5f371ba
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/2fe81913a7ac8d0122ec423db5750e80241def56
branch
September 23, 2026 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix no-reparse directory opens on Windows 10
Why
Windows 10 rejects the Object Manager drive-letter link when opening a directory with
OBJ_DONT_REPARSE, preventing ordinary local-drive paths from opening successfully.What changed
Resolve drive-letter aliases with
QueryDosDeviceWbefore callingNtCreateFile. Accept only direct disk-volume mappings, rejecting other devices and volume subpaths. Leave filesystem components unresolved soOBJ_DONT_REPARSEcontinues to reject filesystem reparse points.Testing
Add tests for drive-root opens and NT path construction using ordinary and verbatim drive paths, plus validation of accepted disk-volume mappings and rejected device or subpath mappings.