Repository navigation
Preserve history search during background draft recovery - #47423
Merged
copyberry[bot] merged 1 commit intoSep 23, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Recovering question answers or interrupted input can cancel an active `Ctrl+R` search or overwrite its preview. Recovery should preserve the search while keeping the recovered input available on cancellation. ## What changed - Apply background updates to the saved draft without changing the search query or visible preview, including when a query has no match. - Restore the updated draft on `Esc` or `Ctrl+C`; discard it when accepting a history match. Keep search open when `Enter` has no match to accept. - Capture the saved draft rather than the preview in draft snapshots, preserving attachments, mention bindings, and pending pastes. - End search on an explicit fresh draft replacement so cancellation cannot resurrect discarded input. ## Testing Add regression coverage for recovery on turn completion, failure, and interruption; accepting and canceling search after recovery; Vim undo/redo; pending paste preservation; and clearing drafts after a misalignment policy failure. GitOrigin-RevId: d3de19bbbcdab2e461c19d47b2b7dca0b28f6ff3
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/d3de19bbbcdab2e461c19d47b2b7dca0b28f6ff3
branch
from
September 23, 2026 01:41
4ea2722 to
3032b38
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/d3de19bbbcdab2e461c19d47b2b7dca0b28f6ff3
branch
September 23, 2026 01:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve history search during background draft recovery
Why
Recovering question answers or interrupted input can cancel an active
Ctrl+Rsearch or overwrite its preview. Recovery should preserve the search while keeping the recovered input available on cancellation.What changed
EscorCtrl+C; discard it when accepting a history match. Keep search open whenEnterhas no match to accept.Testing
Add regression coverage for recovery on turn completion, failure, and interruption; accepting and canceling search after recovery; Vim undo/redo; pending paste preservation; and clearing drafts after a misalignment policy failure.