Skip to content

Support model-catalog overrides for Code Mode tool messages - #47118

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e542a0cd47a7138a414871192cee47790ed1214e
Sep 21, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e542a0cd47a7138a414871192cee47790ed1214e

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Support model-catalog overrides for Code Mode tool messages

What changed

  • Add tools.code_mode catalog messages for exec, wait, deferred-tool guidance, and shared MCP TypeScript definitions.
  • Render {{ default_exec_yield_time_ms }} and {{ image_helper }} in exec descriptions while preserving runtime tool declarations and the freeform grammar.
  • Resolve wait descriptions and parameter schemas independently, falling back to bundled parameters for invalid or unsupported schemas.
  • Use the active model's Code Mode messages, including after mid-turn model changes. Missing overrides retain bundled defaults; empty text overrides suppress the corresponding text.

Testing

Add coverage for literal template substitution, runtime section preservation, independent wait overrides and fallback behavior, mid-turn model changes, and a yielded cell completing through wait with catalog messages.

## What changed

- Add `tools.code_mode` catalog messages for `exec`, `wait`, deferred-tool guidance, and shared MCP TypeScript definitions.
- Render `{{ default_exec_yield_time_ms }}` and `{{ image_helper }}` in `exec` descriptions while preserving runtime tool declarations and the freeform grammar.
- Resolve `wait` descriptions and parameter schemas independently, falling back to bundled parameters for invalid or unsupported schemas.
- Use the active model's Code Mode messages, including after mid-turn model changes. Missing overrides retain bundled defaults; empty text overrides suppress the corresponding text.

## Testing

Add coverage for literal template substitution, runtime section preservation, independent `wait` overrides and fallback behavior, mid-turn model changes, and a yielded cell completing through `wait` with catalog messages.

GitOrigin-RevId: e542a0cd47a7138a414871192cee47790ed1214e
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/e542a0cd47a7138a414871192cee47790ed1214e branch from e6ff6b6 to 5aa4939 Compare September 21, 2026 22:49
@copyberry
copyberry Bot merged commit 5aa4939 into main Sep 21, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/e542a0cd47a7138a414871192cee47790ed1214e branch September 21, 2026 22:49
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 21, 2026
@amarilio
amarilio deployed to issue-triage September 21, 2026 22:50 — with GitHub Actions Active
@amarilio
amarilio deployed to issue-triage September 21, 2026 22:50 — with GitHub Actions Active
@amarilio
amarilio deployed to issue-triage September 21, 2026 22:50 — with GitHub Actions Active
@amarilio
amarilio deployed to issue-triage September 21, 2026 22:51 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 5aa4939b Deployed Sep 21, 2026 by amarilio via Identify potential duplicates (open issues fallback) #47254
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants