Repository navigation
Preserve originating turn metadata for yielded skill calls - #47106
Merged
copyberry[bot] merged 1 commit intoSep 21, 2026
Conversation
## Why Code Mode callbacks can retain skill tools after another turn becomes active. Looking up the active turn when a delayed skill invocation completes can lose access to the originating turn's metrics and metadata. ## What changed - Capture and retain the originating `SkillTurnMetrics` when constructing skill analytics. - Expose turn analytics metadata through the turn extension store and carry it into skill telemetry. - Add optional turn metadata to `TrackEventsContext` and pass it from app, skill, and plugin usage call sites. ## Testing Add a regression test that yields a Code Mode cell, starts another turn, and releases both skill reads through a shared barrier. Assert that each `skill_invocation` event retains its originating `turn_id`. GitOrigin-RevId: aa629dd5f84563d558aa6a86bfbdfc356f1b98e4
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/aa629dd5f84563d558aa6a86bfbdfc356f1b98e4
branch
from
September 21, 2026 20:34
ea8e8ad to
6a601c0
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/aa629dd5f84563d558aa6a86bfbdfc356f1b98e4
branch
September 21, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve originating turn metadata for yielded skill calls
Why
Code Mode callbacks can retain skill tools after another turn becomes active. Looking up the active turn when a delayed skill invocation completes can lose access to the originating turn's metrics and metadata.
What changed
SkillTurnMetricswhen constructing skill analytics.TrackEventsContextand pass it from app, skill, and plugin usage call sites.Testing
Add a regression test that yields a Code Mode cell, starts another turn, and releases both skill reads through a shared barrier. Assert that each
skill_invocationevent retains its originatingturn_id.