Skip to content

Cancel pending transcript Home jumps on subsequent navigation - #46722

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/438c3289afee2719655b11dbc43a3ccb006a5fa3
Sep 19, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/438c3289afee2719655b11dbc43a3ccb006a5fa3

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Cancel pending transcript Home jumps on subsequent navigation

Why

Pressing Home while older transcript history is loading leaves a pending jump to the beginning. Subsequent navigation should supersede that jump so arriving history does not override the user's new reading position.

What changed

Cancel the pending jump when scrolling, jumping to the latest entry, or navigating prompts in the read-only transcript viewer. Keep the in-flight history page by switching from LoadingBeginning to LoadingOlder. Handle navigation before the first draw as well as after rendering, while preserving pending jumps during passive highlight restoration.

Testing

Add regression coverage for navigation after Home before and after the first draw, checking that arriving older history preserves the expected viewport. Extend prompt backtracking tests to verify that navigation clears the pending jump.

## Why

Pressing `Home` while older transcript history is loading leaves a pending jump to the beginning. Subsequent navigation should supersede that jump so arriving history does not override the user's new reading position.

## What changed

Cancel the pending jump when scrolling, jumping to the latest entry, or navigating prompts in the read-only transcript viewer. Keep the in-flight history page by switching from `LoadingBeginning` to `LoadingOlder`. Handle navigation before the first draw as well as after rendering, while preserving pending jumps during passive highlight restoration.

## Testing

Add regression coverage for navigation after `Home` before and after the first draw, checking that arriving older history preserves the expected viewport. Extend prompt backtracking tests to verify that navigation clears the pending jump.

GitOrigin-RevId: 438c3289afee2719655b11dbc43a3ccb006a5fa3
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/438c3289afee2719655b11dbc43a3ccb006a5fa3 branch from 49b5ac6 to 392f56a Compare September 19, 2026 21:44
@copyberry
copyberry Bot merged commit 392f56a into main Sep 19, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/438c3289afee2719655b11dbc43a3ccb006a5fa3 branch September 19, 2026 21:44
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 19, 2026
@akin-umit
akin-umit deployed to issue-triage September 19, 2026 22:32 — with GitHub Actions Active
@akin-umit
akin-umit deployed to issue-triage September 19, 2026 22:32 — with GitHub Actions Active
@akin-umit
akin-umit deployed to issue-triage September 19, 2026 22:32 — with GitHub Actions Active
@aranja15
aranja15 deployed to issue-triage September 19, 2026 22:41 — with GitHub Actions Active
@aranja15
aranja15 deployed to issue-triage September 19, 2026 22:41 — with GitHub Actions Active
@aranja15
aranja15 deployed to issue-triage September 19, 2026 22:41 — with GitHub Actions Active
@mynyml
mynyml deployed to issue-triage September 19, 2026 22:58 — with GitHub Actions Active
@mynyml
mynyml deployed to issue-triage September 19, 2026 22:58 — with GitHub Actions Active
@mynyml
mynyml deployed to issue-triage September 19, 2026 22:58 — with GitHub Actions Active
@Mooness87
Mooness87 deployed to issue-triage September 19, 2026 23:08 — with GitHub Actions Active
@Mooness87
Mooness87 deployed to issue-triage September 19, 2026 23:08 — with GitHub Actions Active
@Mooness87
Mooness87 deployed to issue-triage September 19, 2026 23:08 — with GitHub Actions Active
@Mooness87
Mooness87 deployed to issue-triage September 19, 2026 23:09 — with GitHub Actions Active
@mankpr
mankpr deployed to issue-triage September 19, 2026 23:14 — with GitHub Actions Active
@mankpr
mankpr deployed to issue-triage September 19, 2026 23:14 — with GitHub Actions Active
@mankpr
mankpr deployed to issue-triage September 19, 2026 23:14 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 392f56a6 Deployed Sep 19, 2026 by mankpr via Translate non-English issue #14135
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants