Repository navigation
Stabilize the TUI exit interruption test - #46517
Merged
copyberry[bot] merged 1 commit intoSep 18, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why The test launches a real shell, but its fixture uses a working directory that does not exist on clean runners. Waiting only for a turn-start notification also does not establish that the shell is running before interruption. ## What changed - Give `exit_interrupts_before_requesting_shutdown` a temporary working directory. - Replace the fixed 30-second sleep with a loop that stays alive while a temporary directory exists, with cleanup allowing the command to finish if the test fails early. - Wait for both the turn ID and `exit-test-ready` output within a single 10-second timeout, and fail immediately if the turn completes before interruption. GitOrigin-RevId: d8f92b941b3fe8a077f447c6bf705a2ef922db03
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/d8f92b941b3fe8a077f447c6bf705a2ef922db03
branch
from
September 18, 2026 23:48
33dd893 to
e811c28
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/d8f92b941b3fe8a077f447c6bf705a2ef922db03
branch
September 18, 2026 23:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilize the TUI exit interruption test
Why
The test launches a real shell, but its fixture uses a working directory that does not exist on clean runners. Waiting only for a turn-start notification also does not establish that the shell is running before interruption.
What changed
exit_interrupts_before_requesting_shutdowna temporary working directory.exit-test-readyoutput within a single 10-second timeout, and fail immediately if the turn completes before interruption.