Repository navigation
Handle disabled Windows sandbox accounts during cleanup - #46333
Merged
copyberry[bot] merged 1 commit intoSep 18, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Cleanup needs fresh logon tokens for sandbox accounts that may already be disabled. Temporarily enabling those accounts must leave a durable obligation to disable them again if the service exits unexpectedly. ## What changed - Persist `cleanup_logon_pending` before enabling an account, then disable it again after the logon attempt before clearing the marker. - Recover pending account disables before owner restoration or IPC admission, validating account SIDs before restoration. Block runtime readiness and provisioning while recovery is pending, and defer retirement until cleanup logons are prepared. - Include the blocking logon details in cleanup timeout errors and suppress repeated identical cleanup errors in the Windows event log. ## Testing Add receipt tests covering backward-compatible defaults and pending cleanup state surviving serialization, blocking readiness and owner admission until cleared. GitOrigin-RevId: 801bec408a27ac85ccdc3eb5ca2bdb2ccb3d5827
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/801bec408a27ac85ccdc3eb5ca2bdb2ccb3d5827
branch
from
September 18, 2026 00:36
eac997c to
fd875b1
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/801bec408a27ac85ccdc3eb5ca2bdb2ccb3d5827
branch
September 18, 2026 00:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle disabled Windows sandbox accounts during cleanup
Why
Cleanup needs fresh logon tokens for sandbox accounts that may already be disabled. Temporarily enabling those accounts must leave a durable obligation to disable them again if the service exits unexpectedly.
What changed
cleanup_logon_pendingbefore enabling an account, then disable it again after the logon attempt before clearing the marker.Testing
Add receipt tests covering backward-compatible defaults and pending cleanup state surviving serialization, blocking readiness and owner admission until cleared.