Repository navigation
Separate thread startup metadata from replay history - #46294
Merged
copyberry[bot] merged 1 commit intoSep 17, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why `CodexThread` retained the full `SessionConfiguredEvent`, including initial replay messages, and cloned it even for callers that only needed thread or session IDs. ## What changed Store `ThreadStartupMetadata` without replay history and expose it by reference through `startup_metadata()`. Update callers to read IDs from this metadata. When rejoining a running thread, rebuild the startup response using the supplied resume history for `initial_messages`. ## Testing Extend the resume test to verify that rejoining reuses the loaded thread, preserves startup metadata, and still returns the original replay messages as a prefix. GitOrigin-RevId: 9d656063088c28f091d29e5862e4b9d894b7642c
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/9d656063088c28f091d29e5862e4b9d894b7642c
branch
from
September 17, 2026 19:55
dcca1f3 to
17baabd
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/9d656063088c28f091d29e5862e4b9d894b7642c
branch
September 17, 2026 19:55
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate thread startup metadata from replay history
Why
CodexThreadretained the fullSessionConfiguredEvent, including initial replay messages, and cloned it even for callers that only needed thread or session IDs.What changed
Store
ThreadStartupMetadatawithout replay history and expose it by reference throughstartup_metadata(). Update callers to read IDs from this metadata. When rejoining a running thread, rebuild the startup response using the supplied resume history forinitial_messages.Testing
Extend the resume test to verify that rejoining reuses the loaded thread, preserves startup metadata, and still returns the original replay messages as a prefix.