Repository navigation
Filter saved reasoning overrides from requests when disabled - #46291
Merged
copyberry[bot] merged 1 commit intoSep 17, 2026
Conversation
## Why Resuming a thread after disabling reasoning effort overrides still sent saved `configuration_update` items until compaction. Disabling the feature should also apply to requests built from existing history. ## What changed Pass the `ReasoningEffortOverride` feature state into `ModelClient` and filter `configuration_update` items from request input when disabled. Preserve persisted history and other input items while using the request-level reasoning effort. ## Testing Add regression coverage for resumed threads, compaction, and WebSocket warmup and turn requests. Verify that saved updates remain in history and `agent_message` items remain in request input. GitOrigin-RevId: aac3257da1ca38a0744807c4f7cb12565bd7fe53
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/aac3257da1ca38a0744807c4f7cb12565bd7fe53
branch
from
September 17, 2026 19:43
c64864a to
47915ce
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/aac3257da1ca38a0744807c4f7cb12565bd7fe53
branch
September 17, 2026 19:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter saved reasoning overrides from requests when disabled
Why
Resuming a thread after disabling reasoning effort overrides still sent saved
configuration_updateitems until compaction. Disabling the feature should also apply to requests built from existing history.What changed
Pass the
ReasoningEffortOverridefeature state intoModelClientand filterconfiguration_updateitems from request input when disabled. Preserve persisted history and other input items while using the request-level reasoning effort.Testing
Add regression coverage for resumed threads, compaction, and WebSocket warmup and turn requests. Verify that saved updates remain in history and
agent_messageitems remain in request input.