Repository navigation
Preserve uploaded image file IDs in user message display history - #46258
Merged
copyberry[bot] merged 1 commit intoSep 17, 2026
Conversation
) ## Why Image preparation replaces uploaded images with file references in model history, but user message events still retain the original local paths or inline image URLs. Live and persisted display history should carry the prepared file IDs as well. ## What changed - Prepare images before emitting user message events, and copy uploaded file IDs into the corresponding user inputs. - Track original input positions through content expansion so failed image reads, omitted inputs, and duplicate URLs do not misassociate images. - Preserve text spans, image detail settings, and inputs without a prepared file reference. ## Testing Add a protocol test for image position mapping and an integration test covering file IDs in model requests, live user message events, and persisted display history, including failed images and duplicate URLs. GitOrigin-RevId: 55e7ab97925b5db049c5c2403d90349635eee740
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/55e7ab97925b5db049c5c2403d90349635eee740
branch
from
September 17, 2026 17:17
74e15b9 to
96aca98
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/55e7ab97925b5db049c5c2403d90349635eee740
branch
September 17, 2026 17:17
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve uploaded image file IDs in user message display history
Why
Image preparation replaces uploaded images with file references in model history, but user message events still retain the original local paths or inline image URLs. Live and persisted display history should carry the prepared file IDs as well.
What changed
Testing
Add a protocol test for image position mapping and an integration test covering file IDs in model requests, live user message events, and persisted display history, including failed images and duplicate URLs.