Skip to content

Preserve executor path URIs in permission profile workspace roots - #45863

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/903c068fd74959bdd10e7cb1141aa42b953a59a4
Sep 16, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/903c068fd74959bdd10e7cb1141aa42b953a59a4

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Preserve executor path URIs in permission profile workspace roots

Why

Executor profile roots can use path conventions that are not native to the current host. Converting them to host paths during configuration or turn reconstruction can reject or drop those roots, while case-insensitive comparison can hide Windows path spelling changes.

What changed

  • Store profile roots as URI-backed ProfileWorkspaceRoot values throughout permission snapshots and thread settings, preserving spelling in equality and deduplication.
  • Keep effective workspace roots as PathUri values for permission materialization and status summaries. Convert Windows sandbox root hints to native paths only at native Windows sandbox boundaries, rejecting incompatible roots.
  • Omit the legacy rollout workspace_roots field when profile roots cannot be represented as host paths, retaining the compiled permission profile.

Testing

Add regression coverage for Windows and UNC root spelling changes, settings restoration and turn recording with foreign roots, executor-root status display, and backend-specific Windows root conversion.

…5863)

## Why

Executor profile roots can use path conventions that are not native to the current host. Converting them to host paths during configuration or turn reconstruction can reject or drop those roots, while case-insensitive comparison can hide Windows path spelling changes.

## What changed

- Store profile roots as URI-backed `ProfileWorkspaceRoot` values throughout permission snapshots and thread settings, preserving spelling in equality and deduplication.
- Keep effective workspace roots as `PathUri` values for permission materialization and status summaries. Convert Windows sandbox root hints to native paths only at native Windows sandbox boundaries, rejecting incompatible roots.
- Omit the legacy rollout `workspace_roots` field when profile roots cannot be represented as host paths, retaining the compiled permission profile.

## Testing

Add regression coverage for Windows and UNC root spelling changes, settings restoration and turn recording with foreign roots, executor-root status display, and backend-specific Windows root conversion.

GitOrigin-RevId: 903c068fd74959bdd10e7cb1141aa42b953a59a4
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/903c068fd74959bdd10e7cb1141aa42b953a59a4 branch from 886d77e to 83dc7d1 Compare September 16, 2026 04:23
@copyberry
copyberry Bot merged commit 83dc7d1 into main Sep 16, 2026
1 check failed
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/903c068fd74959bdd10e7cb1141aa42b953a59a4 branch September 16, 2026 04:24
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 16, 2026
@iddictive
iddictive deployed to issue-triage September 16, 2026 04:41 — with GitHub Actions Active
@iddictive
iddictive deployed to issue-triage September 16, 2026 04:41 — with GitHub Actions Active
@iddictive
iddictive deployed to issue-triage September 16, 2026 04:41 — with GitHub Actions Active
@vkabc
vkabc deployed to issue-triage September 16, 2026 04:59 — with GitHub Actions Active
@vkabc
vkabc deployed to issue-triage September 16, 2026 04:59 — with GitHub Actions Active
@vkabc
vkabc deployed to issue-triage September 16, 2026 04:59 — with GitHub Actions Active
@vkabc
vkabc deployed to issue-triage September 16, 2026 05:00 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 83dc7d11 Deployed Sep 16, 2026 by vkabc via Identify potential duplicates (open issues fallback) #45899
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants