Skip to content

Move Guardian reviewer configuration into the extension - #45729

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/dfa1dae9f8d4469f2e4f6e64ab842cc662970898
Sep 15, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/dfa1dae9f8d4469f2e4f6e64ab842cc662970898

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Move Guardian reviewer configuration into the extension

What changed

Move concrete reviewer settings into guardian-v2 and replace ReviewerConfigOverrides with a ReviewerConfig callback stored in thread extension data. Apply the callback to each captured parent configuration before preparing context and checking session reuse.

Keep model selection, policy prompt construction, and live network state in the core adapter. Preserve the existing read-only reviewer settings and share reviewer_permission_profile with inherited environment configuration.

Testing

Update existing Guardian configuration, session reuse, and prewarming tests to use the extension's actual configuration builder, including compiling the shared source in core's test host.

## What changed

Move concrete reviewer settings into `guardian-v2` and replace `ReviewerConfigOverrides` with a `ReviewerConfig` callback stored in thread extension data. Apply the callback to each captured parent configuration before preparing context and checking session reuse.

Keep model selection, policy prompt construction, and live network state in the core adapter. Preserve the existing read-only reviewer settings and share `reviewer_permission_profile` with inherited environment configuration.

## Testing

Update existing Guardian configuration, session reuse, and prewarming tests to use the extension's actual configuration builder, including compiling the shared source in core's test host.

GitOrigin-RevId: dfa1dae9f8d4469f2e4f6e64ab842cc662970898
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/dfa1dae9f8d4469f2e4f6e64ab842cc662970898 branch from 619cf6d to a9d2564 Compare September 15, 2026 16:23
@copyberry
copyberry Bot merged commit a9d2564 into main Sep 15, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/dfa1dae9f8d4469f2e4f6e64ab842cc662970898 branch September 15, 2026 16:23
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant