Repository navigation
Classify MCP auth and approval outcomes in analytics - #45716
Merged
copyberry[bot] merged 1 commit intoSep 15, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed - Record `auth_or_link` for Codex app calls with trusted connector authentication failure metadata, capturing it before result callbacks or model-facing rewrites. Propagate the classification to MCP tool-call and app-usage analytics. - Record `approval` when a dispatched approval request is denied, times out, or aborts, covering both MCP elicitation and legacy user-input approvals. ## Testing Add unit and turn-level coverage for authentication failures, metadata removal by callbacks, successful and rejected approvals, and closed approval response channels. Verify event counts, classification, and exclusion of sensitive test values and authentication URLs from analytics payloads. GitOrigin-RevId: 493df2a2923f346a0f644f1f26ab8b6b9b8888e0
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/493df2a2923f346a0f644f1f26ab8b6b9b8888e0
branch
from
September 15, 2026 15:03
cebd98f to
7784318
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/493df2a2923f346a0f644f1f26ab8b6b9b8888e0
branch
September 15, 2026 15:03
carlosmanuelfernandezsosa2004-ui
deployed
to
issue-triage
September 15, 2026 16:20 — with 
GitHub Actions
Active
GitHub Actions
Active
carlosmanuelfernandezsosa2004-ui
deployed
to
issue-triage
September 15, 2026 16:20 — with
GitHub Actions
Active
GitHub Actions
Active
carlosmanuelfernandezsosa2004-ui
deployed
to
issue-triage
September 15, 2026 16:20 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classify MCP auth and approval outcomes in analytics
What changed
auth_or_linkfor Codex app calls with trusted connector authentication failure metadata, capturing it before result callbacks or model-facing rewrites. Propagate the classification to MCP tool-call and app-usage analytics.approvalwhen a dispatched approval request is denied, times out, or aborts, covering both MCP elicitation and legacy user-input approvals.Testing
Add unit and turn-level coverage for authentication failures, metadata removal by callbacks, successful and rejected approvals, and closed approval response channels. Verify event counts, classification, and exclusion of sensitive test values and authentication URLs from analytics payloads.