Repository navigation
Share MCP tool specs until search results are selected - #45509
Merged
copyberry[bot] merged 1 commit intoSep 14, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Building MCP search entries eagerly cloned tool specs and normalized schemas even for tools that were never selected. ## What changed Store search specs in `Arc` and let MCP search entries share the handler's spec. Materialize and normalize loadable specs only for selected results, preserving existing result formatting and dynamic-tool cache equality behavior. ## Testing Add coverage for function, freeform, and namespace specs that verifies shared specs produce equivalent results, retain the source while needed, and release it when the search entry is dropped. GitOrigin-RevId: 4260f2e2527834d8a856b1528654c6951aab8a7d
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/4260f2e2527834d8a856b1528654c6951aab8a7d
branch
from
September 14, 2026 20:20
758bbad to
ea3c484
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/4260f2e2527834d8a856b1528654c6951aab8a7d
branch
September 14, 2026 20:20
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share MCP tool specs until search results are selected
Why
Building MCP search entries eagerly cloned tool specs and normalized schemas even for tools that were never selected.
What changed
Store search specs in
Arcand let MCP search entries share the handler's spec. Materialize and normalize loadable specs only for selected results, preserving existing result formatting and dynamic-tool cache equality behavior.Testing
Add coverage for function, freeform, and namespace specs that verifies shared specs produce equivalent results, retain the source while needed, and release it when the search entry is dropped.